Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow customizing p-drawer teleport location #1525

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

znicholasbrown
Copy link
Contributor

Makes this a little easier to work with in local contexts

@znicholasbrown znicholasbrown requested a review from a team as a code owner November 21, 2024 21:28
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 37ace1a
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/673fa5e82437cb00087f359e
😎 Deploy Preview https://deploy-preview-1525--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -37,13 +37,15 @@
open?: boolean,
resizable?: boolean,
placement?: DrawerPlacement,
to?: string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd destructure this and default it to body still

@znicholasbrown znicholasbrown merged commit 6365efc into main Nov 21, 2024
6 checks passed
@znicholasbrown znicholasbrown deleted the enhancement/p-drawer-teleport/2024-11-21 branch November 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants