Add sizes for tags #1065
Merged
Add sizes for tags #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
collincchoy
commented
Dec 20, 2023
•
collincchoy
commented
collincchoy
requested review from
pleek91,
znicholasbrown,
zhen0 and
brandonreid
as code owners
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonreid
approved these changes
Dec 20, 2023
brandonreid
reviewed
Dec 20, 2023
src/components/Tag/PTag.vue
Outdated
| icon?: Icon, | ||
| label?: string, | ||
| value?: string | TagValue, | ||
| dismissible?: boolean, | ||
| }>() | ||
| size?: 'xs' | 'sm', |
There was a problem hiding this comment.
To be a little more semantically prescriptive, maybe the terms here would be better suited as 'sm' | 'default'? Or, like buttons, we ended up refactoring to just the default and a bool prop called small.
There was a problem hiding this comment.
I'm like 98.6% sure we'll never add a large for tags
There was a problem hiding this comment.
👍 will shoot for consistency. size -> small?: boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.