Fix: tags input not taking advantage of available width #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonreid
requested review from
pleek91,
znicholasbrown and
zhen0
as code owners
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonreid
commented
Dec 14, 2023
|
|
||
| const containerBoundingBox = container.value!.getBoundingClientRect() | ||
| const calculateOverflow = (): void => { |
There was a problem hiding this comment.
I did a little cleanup in this function but not a full refactor.
|
Overall code looks fine to me. But when I viewed the demo it seemed like it wasn't working correctly in the tags demo |
|
@brandonreid this seems to be working much better. One thing I found while testing in the demo though is if you shrink the inline one down and then expand it it won't always expand to show all the tags. Most reproducible when expanding more slowely. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags input required a fixed width to really take advantage of the
+noverflow display. This made it so the input was unusually long on the dashboard or never read out the selected tags:This PR makes it so that the tags list has an inline option and will allow the input to scale with the content.
Screen.Recording.2023-12-14.at.3.24.42.PM.mov
Screen.Recording.2023-12-14.at.3.27.11.PM.mov