Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional input for providing a working dir #14

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

pleek91
Copy link
Contributor

@pleek91 pleek91 commented Jan 15, 2025

Description

In the graphs repo the project to be built and published to npm is nested within a core directory. Adding and optional input to this action for WORKING_DIR which defaults to . so that the graph repo can specify ./core as its working dir

@pleek91 pleek91 requested a review from jimid27 January 15, 2025 16:04
Copy link
Collaborator

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once readme is updated I'll approve!

@@ -17,6 +17,10 @@ inputs:
description: Skip the build step.
required: true
default: 'false'
WORKING_DIR:
Copy link
Collaborator

@jimid27 jimid27 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding what this input does to the README?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 37ed848

Copy link
Collaborator

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pleek91 pleek91 merged commit 8b1fe50 into main Jan 15, 2025
1 check passed
@pleek91 pleek91 deleted the add-working-dir-input branch January 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants