Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same package versions on cluster machines as source #19

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

eliotmcintire
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (8bc646d) 2.08% compared to head (4962e53) 2.06%.

Files Patch % Lines
R/DEoptim_fns.R 0.00% 46 Missing ⚠️
R/objFunSpread.R 0.00% 14 Missing ⚠️
R/cleanUpSpreadFirePoints.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           development     #19      +/-   ##
==============================================
- Coverage         2.08%   2.06%   -0.03%     
==============================================
  Files               25      25              
  Lines             1579    1596      +17     
==============================================
  Hits                33      33              
- Misses            1546    1563      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# there won't be a folder present that is writable
if (!dir.exists(libPath)) {
dir.create(libPath, recursive = TRUE)
aa <- Require::pkgDep(unique(c("dqrng", "PredictiveEcology/SpaDES.tools@development",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be careful allowing Require to install update anything without specifying exact versions (i.e., those installed on the main node); otherwise we get mismatched packages on each node.

Can you confirm that the versions installed are exactly the same, and that it's not just grabbing the latest versions of everything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't installing them ... this is just determining which to use. It copies them from the source folder. Previously this was not checking versions. Now it is using the exact version because they are being copied.


## Use the binary packages for install if Ubuntu & Linux
Require::setLinuxBinaryRepo()
#scp -r /home/emcintir/.local/share/R/Edehzhie/packages/x86_64-pc-linux-gnu/4.3/fireSenseUtils emcintir@10.│^C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@ianmseddy ianmseddy merged commit 5c90962 into development Jul 9, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants