Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #17

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

tati-micheletti
Copy link
Contributor

I was hitting the following error with the previous code:

Error in lociDF$size/(prod(res(ras))/divisor) :
  non-numeric argument to binary operator

I tracked down to the column size of the data.table lociDF being character and not numeric, while used below in a mathematical division:

lociDF$size/(prod(res(ras))/divisor)

My PR made sure this column will always be numeric and will warn user about the transformation.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@ianmseddy ianmseddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the warning?

@ianmseddy ianmseddy merged commit 6f81b21 into PredictiveEcology:development Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants