Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module tests added: with defaults and with a user input masterRaster AOI (IN PROGRESS) #10

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

module tests added: with defaults and with a user input masterRaster AOI (IN PROGRESS) #10

wants to merge 1 commit into from
+634 −88

Conversation

suz-estella
Copy link

Things left to address:

  1. Output validation is based on the results created by the module as it is now. These should be reviewed to ensure that these results are indeed correct.
  2. Formatting considerations:
  • Running simInit and spades inside or outside of a test_that call: pros and cons (consider warnings)
  • Test set up manually with tests/runTest.R vs. adding a DESCRIPTION file

suz-estella
suz-estella commented Dec 10, 2024
View reviewed changes
tests/testthat/setup.R

# Set directory paths
testDirs <- list(
module = ifelse(testthat::is_testing(), dirname(dirname(getwd())), getwd()),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to set the module path?

@suz-estella suz-estella changed the title module tests added: with defaults and with a user input masterRaster AOI module tests added: with defaults and with a user input masterRaster AOI (IN PROGRESS) Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suz-estella