feat: paginated event archive pruning#752
Merged
greatest0fallt1me merged 1 commit intoJun 28, 2026
Merged
Conversation
- Document paginated pruning cursor pattern in module-level rustdoc - Add seed_archive test helper for direct storage state setup - Add 7 focused unit tests covering: * None cursor starts from beginning * Cursor resume continues from last position (multi-page) * done flag set when archive exhausted * done cursor is idempotent (no double-removal) * Oldest-first ordering preserved regardless of insertion order * count capped at MAX_QUERY_LIMIT * Partial last page sets done correctly Closes Predictify-org#722
|
@NEA-DEV-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements paginated event archive pruning for issue #722.
The
PruneCursorstruct andprune_archivefunction already existed. This PR adds:Tests added (
event_archive.rs)test_prune_archive_none_cursor_starts_from_beginningNonecursor starts at index 0test_prune_archive_cursor_resume_continues_from_last_positiontest_prune_archive_done_flag_set_when_exhausteddone=truewhen count exceeds remaining entriestest_prune_archive_done_cursor_is_idempotentdonecursor removes nothingtest_prune_archive_preserves_oldest_first_ordertest_prune_archive_count_capped_at_max_query_limitcountcapped atMAX_QUERY_LIMIT=30test_prune_archive_partial_page_then_donedone=trueCloses
Closes #722