Example commit message#684
Merged
Conversation
|
@Songu3020 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes
#634
PR title
chore: document create_market rent-preflight blockers
PR description
Summary
Investigated adding a storage-rent preflight to create_market. No code changes were made because the proposed contract-side check cannot be implemented securely with Soroban SDK 25.
Findings
env.storage().instance().get_ttl() is available only through SDK test utilities, not deployed WASM contracts.
Multiplying persistent-key count by TTL and comparing it with a single instance TTL mixes incompatible units and would reject valid market creation.
Actual rent depends on serialized entry sizes and network rent configuration.
Rent must be estimated through transaction simulation before submission.
Recommended approach
Validate configured TTL targets against env.storage().max_ttl() on-chain.
Perform actual rent estimation and fee validation client-side using Soroban transaction simulation.
Avoid presenting instance TTL as proof that the caller paid sufficient rent.
Verification
Command:
cargo test -p predictify-hybrid market_creation_validation_tests -- --nocapture
Baseline compilation currently fails in require_auth_coverage_tests.rs because four oracle configuration calls omit the new max_deviation_bps: Option argument.
Notes
Working tree remains clean.
No unwrap() calls or dependency changes were introduced.
Implementation requires agreement on the feasible client-side simulation/on-chain TTL-validation design.