feat: bounded ContractMonitor queue with overflow signaling#647
Merged
greatest0fallt1me merged 1 commit intoJun 27, 2026
Merged
Conversation
- Add MONITOR_QUEUE_CAP = 100 constant to config.rs - Replace unbounded store_alert (single-key overwrite) with a FIFO Vec<MonitoringAlert> capped at MONITOR_QUEUE_CAP entries stored under the 'MON_QUEUE' persistent key - Set 'MON_OVERFLOWED' flag to true whenever the oldest entry is evicted to make capacity exhaustion observable to operators - Avoid Vec::remove(0) in the hot path; eviction rebuilds via index loop - Add ContractMonitor::get_alerts, is_overflow, clear_overflow (admin- gated via require_auth + stored-admin check, no unwrap()) - Expose get_monitor_alerts, is_monitor_overflow, clear_monitor_overflow as public contract entrypoints in lib.rs - Add bounded_queue_tests module covering: empty initial state, single insert, FIFO eviction at cap, cap-edge case, repeated overflow, admin clear, unauthorized clear rejection, and emit path Closes Predictify-org#622
|
@DavidAkere204 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀