refactor: add edge_cases and improve code structure in various modules#174
Merged
Merged
Conversation
…dules - Cleaned up unused imports and reordered them for better readability in `admin.rs`, `batch_operations.rs`, `circuit_breaker.rs`, `fees.rs`, `markets.rs`, `oracles.rs`, `resolution.rs`, and `voting.rs`. - Enhanced test organization and structure in `batch_operations_tests.rs` and `circuit_breaker_tests.rs` for improved clarity and maintainability. - Introduced a new module `edge_cases.rs` for comprehensive edge case management in the Predictify Hybrid contract, including handling zero stakes, tie-breaking, orphaned markets, and partial resolutions. - Updated `lib.rs` to integrate edge case handling functions, enhancing the contract's robustness against edge scenarios. Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
pushkarm029
changed the title
Contributor
|
@pushkarm029 Please resolve the conflicts |
…ning and monitoring
- Change validation conditions in GovernanceContract to check for zero values instead of negative values for voting period and quorum votes. - Refactor function signatures in PredictifyHybrid and ContractMonitor for improved readability by aligning parameters. - Clean up imports and formatting in monitoring and versioning modules for consistency and clarity. Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Contributor
Author
|
@greatest0fallt1me conflicts resolved. please have a look. |
Contributor
|
@pushkarm029 Thanks for the contribution, great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
📋 Basic Information
Type of Change
Related Issues
Closes #91
Priority Level
📝 Detailed Description
admin.rs,batch_operations.rs,circuit_breaker.rs,fees.rs,markets.rs,oracles.rs,resolution.rs, andvoting.rs.batch_operations_tests.rsandcircuit_breaker_tests.rsfor improved clarity and maintainability.edge_cases.rsfor comprehensive edge case management in the Predictify Hybrid contract, including handling zero stakes, tie-breaking, orphaned markets, and partial resolutions.lib.rsto integrate edge case handling functions, enhancing the contract's robustness against edge scenarios.Thank you for your contribution to Predictify! 🚀