Skip to content

feat: Implement comprehensive MarketParameterValidator for robust market creation #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatest0fallt1me merged 2 commits into from
Aug 20, 2025
Merged

feat: Implement comprehensive MarketParameterValidator for robust market creation #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a28c014
feat: implement comprehensive market parameter validation
Jagadeeshftw Aug 20, 2025
1a5cb51
fix: update validation test for duplicate outcomes to check for exact…
Jagadeeshftw Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions contracts/predictify-hybrid/src/markets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

use soroban_sdk::{contracttype, token, vec, Address, Env, Map, String, Symbol, Vec};

use crate::config;
use crate::errors::Error;
use crate::types::*;
// Oracle imports removed - not currently used
Expand Down Expand Up @@ -449,20 +450,25 @@ impl MarketValidator {
return Err(Error::InvalidQuestion);
}

// Validate outcomes
if outcomes.len() < 2 {
return Err(Error::InvalidOutcomes);
}
// Use the new MarketParameterValidator for comprehensive validation
use crate::validation::MarketParameterValidator;

for outcome in outcomes.iter() {
if outcome.is_empty() {
return Err(Error::InvalidOutcomes);
}
// Validate duration limits
if let Err(_) = MarketParameterValidator::validate_duration_limits(
duration_days,
config::MIN_MARKET_DURATION_DAYS,
config::MAX_MARKET_DURATION_DAYS,
) {
return Err(Error::InvalidDuration);
}

// Validate duration
if duration_days == 0 || duration_days > 365 {
return Err(Error::InvalidDuration);
// Validate outcome count and content
if let Err(_) = MarketParameterValidator::validate_outcome_count(
outcomes,
config::MIN_MARKET_OUTCOMES,
config::MAX_MARKET_OUTCOMES,
) {
return Err(Error::InvalidOutcomes);
}

Ok(())
Expand Down
Loading
Loading