Feat/implement contract upgradeability

[psychemist]

Contract Upgrade & Rollback System

📋 Basic Information

Implements a robust upgrade and rollback system for the Predictify Hybrid contract, including version management, admin controls, event emission, and comprehensive tests. Enables safe contract evolution and operational flexibility for mainnet/testnet deployments.

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• 🧪 Test addition/update
• 🔧 Refactoring (no functional changes)
• ⚡ Performance improvement
• 🔒 Security fix
• 🎨 UI/UX improvement
• 🚀 Deployment/Infrastructure change

Related Issues

Resolves #90

Priority Level

• 🔴 Critical (blocking other development)
• 🟡 High (significant impact)
• 🟢 Medium (moderate impact)
• 🔵 Low (minor improvement)

---

📝 Detailed Description

What does this PR do?

Implements the contract upgrade and rollback system for Predictify Hybrid, including:

• UpgradeManager, UpgradeValidator, RollbackManager, and supporting data structures.
• Upgrade event emission and logging.
• Safety and compatibility checks for upgrades.
• Rollback logic with admin controls and event emission.
• Comprehensive unit tests for upgrade and rollback flows.

Why is this change needed?

This enables safe, auditable, and admin-controlled contract upgrades and rollbacks, which are critical for maintaining and evolving the contract on mainnet/testnet. It ensures upgradability, security, and operational flexibility.

How was this tested?

• Added and ran unit tests for all upgrade and rollback flows, including edge cases (unauthorized, in-progress, no backup/history).
• Manual review of event emission and storage logic.

Alternative Solutions Considered

• Considered a simpler upgrade system without rollback, but chose this for safety and auditability.

---

🏗️ Smart Contract Specific

Contract Changes

Please check all that apply:

• Core contract logic modified
• Oracle integration changes (Pyth/Reflector)
• New functions added
• Existing functions modified
• Storage structure changes
• Events added/modified
• Error handling improved
• Gas optimization
• Access control changes
• Admin functions modified
• Fee structure changes

Oracle Integration

• Pyth oracle integration affected
• Reflector oracle integration affected
• Oracle configuration changes
• Price feed handling modified
• Oracle fallback mechanisms
• Price validation logic

Market Resolution Logic

• Hybrid resolution algorithm changed
• Dispute mechanism modified
• Fee structure updated
• Voting mechanism changes
• Community weight calculation
• Oracle weight calculation

Security Considerations

• Access control reviewed
• Reentrancy protection
• Input validation
• Overflow/underflow protection
• Oracle manipulation protection

---

🧪 Testing

Test Coverage

• Unit tests added/updated
• Integration tests added/updated
• All tests passing locally
• Manual testing completed
• Oracle integration tested
• Edge cases covered
• Error conditions tested
• Gas usage optimized
• Cross-contract interactions tested

Test Results

# Paste test output here
cargo test
# Expected output: All upgrade and rollback tests pass, no failures

Manual Testing Steps

1. Ran all unit tests for upgrade/rollback logic.
2. Verified event emission in storage.
3. Checked admin access control for upgrade/rollback.

---

📚 Documentation

Documentation Updates

• README updated
• Code comments added/updated
• API documentation updated
• Examples updated
• Deployment instructions updated
• Contributing guidelines updated
• Architecture documentation updated

Breaking Changes

Breaking Changes:

• Storage keys for upgrade/rollback data added.
• Admin access control for upgrade/rollback.

Migration Guide:

• Deploy new contract version with upgrade system.
• Ensure admin is set for upgrade/rollback operations.

---

🔍 Code Quality

Code Review Checklist

• Code follows Rust/Soroban best practices
• Self-review completed
• No unnecessary code duplication
• Error handling is appropriate
• Logging/monitoring added where needed
• Security considerations addressed
• Performance implications considered
• Code is readable and well-commented
• Variable names are descriptive
• Functions are focused and small

Performance Impact

• Gas Usage: Minimal, only on upgrade/rollback.
• Storage Impact: Additional keys for upgrade/rollback data.
• Computational Complexity: Low, except during upgrade/rollback.

Security Review

• No obvious security vulnerabilities
• Access controls properly implemented
• Input validation in place
• Oracle data properly validated
• No sensitive data exposed

---

🚀 Deployment & Integration

Deployment Notes

• Network: Testnet/Mainnet
• Contract Address: N/A (new deployment)
• Migration Required: Yes
• Special Instructions: Set admin address after deployment.

Integration Points

• Frontend integration considered
• API changes documented
• Backward compatibility maintained
• Third-party integrations updated

---

📊 Impact Assessment

User Impact

• End Users: No direct impact unless upgrade/rollback is triggered.
• Developers: Can safely upgrade/rollback contract.
• Admins: Gain upgrade/rollback controls.

Business Impact

• Revenue: Enables safer contract evolution.
• User Experience: More reliable contract operations.
• Technical Debt: Reduces risk by enabling safe upgrades.

---

✅ Final Checklist

Pre-Submission

• Code follows Rust/Soroban best practices
• All CI checks passing
• No breaking changes (or breaking changes are documented)
• Ready for review
• PR description is complete and accurate
• All required sections filled out
• Test results included
• Documentation updated

Review Readiness

• Self-review completed
• Code is clean and well-formatted
• Commit messages are clear and descriptive
• Branch is up to date with main
• No merge conflicts

---

📸 Screenshots (if applicable)

• scarb build

🔗 Additional Resources

• Design Document: N/A
• Technical Spec: ₦/A
• Related Discussion: N/A
• External Documentation: N/A

---

💬 Notes for Reviewers

Please pay special attention to:

• Upgrade/rollback safety and access control logic.
• Event emission and storage.
• Test coverage for edge cases.

Questions for reviewers:

• Any suggestions for further hardening upgrade/rollback flows?
• Should we add more granular event logs for upgrade steps?

---

Thank you for your contribution to Predictify! 🚀

[greatest0fallt1me]

@psychemist Can you please fix the pipeline failure?

[psychemist]

on it @greatest0fallt1me

[greatest0fallt1me]

@psychemist Also resolve the conflicts

[greatest0fallt1me]

@psychemist Any updates?