feat(Anikura): add Activity - #11082
Conversation
🖼️ Activity asset previewFresh pixels, hot off the CDN — I lined them all up for inspection. 👀 Anikura (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://i.imgur.com/7J9jL7R.png |
 |
thumbnail | https://i.imgur.com/xK5jHDy.png |
Nekowatch (websites/N/Nekowatch) — creation
| Preview | Source | URL |
|---|---|---|
 |
logo | https://i.imgur.com/LtP6hmP.jpeg |
 |
thumbnail | https://i.imgur.com/Q7jwfg0.png |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7574bc356e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| presenceData.state = 'Viewing Membership' | ||
| break | ||
| } | ||
| case pathname.includes('/search') || searchParams.has('query') || searchParams.has('q'): { |
There was a problem hiding this comment.
When a search is encoded on the browse URL, e.g. /browse?query=one-piece or /browse?q=one-piece, the earlier /browse case matches first and this search branch is never reached, so the user only sees generic browsing/filter text instead of the search query. This branch also reads searchParams.get('search') on the next line but does not include searchParams.has('search') in the condition, so /browse?search=... is missed as well; handle search params before the generic browse case or fold that logic into it.
Useful? React with 👍 / 👎.
| if (titleSpan && titleSpan.textContent?.trim()) { | ||
| return titleSpan.textContent.trim() | ||
| } | ||
| const titleElem = document.querySelector('.anime-title, .show-title, h1[class*="text-snow"], h1') |
There was a problem hiding this comment.
On watch pages the main h1 is the episode title, while the watch branch separately calls getEpisodeTitleFromDOM() for that same heading. If the earlier span selectors are absent, this generic h1 fallback makes showTitle become the episode title, so Discord shows the episode title as the anime and then repeats it in Episode N - ... instead of showing the series name; restrict this fallback to anime info pages or use the watch page's breadcrumb/title element for the series.
Useful? React with 👍 / 👎.
DescriptionAdds a new presence activity for the anime platform Nekowatch.
Supported features:
Settings
Acknowledgements
ScreenshotsProof showing the creation/modification is working as expected
|
…rting properly (idle timer seperate from dynamic video timer), made viewing a anime use the default logo as loading the image takes too long, fixed a issue with the profile username not displaying all the time. Nekowatch isnt optimized so everything is usally slow to load by default.
|
let me know if anything needs changed i will gladly do that. I only uploaded both to one pull request because i have no idea how pull requests actually work this was my first. I imagine my commit messages don't follow the contribute guidelines. you'll have to inform me of those I did read up on it but didnt think it applied to this particular case as they aren't uploaded yet. most of github features are very confusing to me so I might need guidance for some things. I apologize for that. |
2 participants
Description
Adds a new presence activity for the anime platform Anikura.
Supported features:
Settings
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected