fix(YouTube): guard corrupt localStorage in pvPrivacyUI (v6.3.3)#10972
Open
Timeraa wants to merge 1 commit into
Open
fix(YouTube): guard corrupt localStorage in pvPrivacyUI (v6.3.3)#10972Timeraa wants to merge 1 commit into
Timeraa wants to merge 1 commit into
Conversation
The two module-load JSON.parse(localStorage.getItem(...)) calls ran outside any try/catch and threw synchronously on corrupt pmdEnablePrivacy/pmdDisablePrivacy storage, aborting activity load. Wrap in a safeParse that falls back to [].
Contributor
🖼️ Activity asset previewI rummaged through the diff and found these. Finders keepers? No? Fine, they're yours. YouTube (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/logo.png |
 |
thumbnail | https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/thumbnail.jpg |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
Bas950
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belt-and-suspenders hardening for a possible co-trigger of the "raw stack trace on YouTube" field report (extension-side central fix is PreMiD/Extension#781).
The two module-load
JSON.parse(localStorage.getItem(...))calls inpvPrivacyUI.tsran outside any try/catch and threw synchronously at activity load whenpmdEnablePrivacy/pmdDisablePrivacyheld corrupt JSON. Wrapped in a tinysafeParsethat falls back to[].Metadata patch bump
6.3.2 → 6.3.3.Testing
On a YouTube tab:
localStorage.setItem('pmdEnablePrivacy','{bad'), reload. Before: uncaught trace at activity load. After: no trace, activity works.