feat(verify): return explicit 'unregistered' state for unknown batches - #1
Merged
Merged
Conversation
Consumers scanning a batch id no manufacturer has registered now get a clear 'unregistered' outcome instead of a generic not-found. Covers the contract (VerificationResult::Unregistered), backend decoding/serialization and fallback, analytics counts, and the frontend result panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consumers scanning a batch ID that no manufacturer has registered now receive a clear
unregisteredverification outcome instead of a generic not-found.Changes
VerificationResult::Unregisteredvariant;verify_serialreturns it when the batch ID does not exist.unregistered, DB fallback returns it, and analytics counts it as non-genuine. Tests updated (28 passing).Unregistered batchwith an explanatory message.Test plan
cargo test(21) +cargo clippy --lib --tests -- -D warningstypecheck/lint/test(28) /buildtypecheck/lint/build