chore(booking): the two refunding sweeps are gated in DEGRADED maintenance, no-show cancels write history, and the doctrine text matches the sweeps (#1506)

[teetangh]

Summary

1. expire-stale-requests joins FINANCIAL_JOB_NAMES. Its expirePaymentPendingRequests/expireApprovedUnallocatedSubscriptions passes call refundPaymentsForExpired, a refund front-door caller like every other job already in the set, so DEGRADED maintenance now holds it with the rest. detect-consultant-no-shows was already there via fix(booking): auto-complete hands an unattended consultation to the no-show detector instead of closing it first (#1504) #1505.
2. A registry pin gates every future refund-front-door caller, not just today's two. __tests__/maintenance/cron-lock-registry.test.ts gains one assertion that greps scripts/**/*.ts for callers of refundBookingPayment(, refundWholeEventPayments(, refundRemovedAttendeeSeat(, and refundPaymentsForExpired(, and asserts each caller's withCronLock name is in FINANCIAL_JOB_NAMES.
3. Two more money-twin routes drop their status: () => 200 override. app/api/cleanup/process-payouts/route.ts and .../sweep-abandoned-overage-charges/route.ts now fall through to cleanup-route.ts's default statusFor, which reads result.success, mirroring release-earnings/sync-payment-earnings under chore(cron): a Netlify scheduled ticker drives the sub-hourly money sweeps #1390.
4. The no-show cancel writes a BookingStatusHistory row. claimConsultantNoShow in scripts/appointments/detect-consultant-no-shows.ts now runs the CANCELLED transition through transitionConsultationRequest inside prisma.$transaction, instead of a bare consultation.updateMany. The zero-row "someone else moved it" outcome is preserved via IllegalTransitionError catch. Candidate query, grace/handoff constants, refund call and notifications are untouched.
5. Doctrine text corrected in .claude/skills/booking/SKILL.md. Rule 2 no longer claims expire-stale-requests.ts/cleanup-tentative-slots.ts hard-delete tentative holds (fixed by fix(booking): free the last tentative holds by status, and route the last bare slot-status writes through the CAS helpers #1380/[booking][P1 HIGH] reconcile-slot-availability clears isTentative with a blind updateMany — no parent-status/CAS re-check (TOCTOU on paid-tentative slots) #1424's soft-cancel via transitionSlotCompletion). Rule 5 no longer names expirePaymentPendingRequests as the doctrine's counter-example (fixed by [booking][P1 HIGH] expire-stale-requests crons bypass the CAS state machine and the audit trail (raw updateMany, APPROVED->EXPIRED undocumented) #1423's CAS + money-predicate rewrite).
6. docs/booking/18-state-machines.md's reschedule section corrected. COUNTERED is noted as an unreachable enum edge with no writer (the counter-round was removed per lib/booking/reschedule-proposals.ts), and AUTO_ACCEPTED is documented as the second terminal-acceptance state.
7. Glossary linked. docs/booking/README.md links docs/enterprise/00-foundations/07-slots-sessions-glossary.md under Core Concepts.
8. DEGRADED gate noted in both cron references. docs/booking/13-cron-jobs-and-background-tasks.md's Safety paragraphs and docs/maintenance/04-cron-jobs-reference.md's table rows for both jobs now say they are held during DEGRADED as well as OFFLINE.
9. Consolidated train changelog. One new ## Changelog: 2026-09-05 — booking closure train section in docs/booking/05-troubleshooting-and-changelog.md, with one subsection per train PR (fix(booking): weekly availability rows mean the consultant's local day everywhere, and day segments are half-open (#1343, #1342, #1326, #1348, #1415, #1416) #1512, feat(booking): cancellation terms are typed versioned rows with per-org tiers, and a credit-funded partial cancel restores the credit in full (#1499, #1500, #1372) #1513, fix(dashboard): the consultant Home badge counts personal requests like the card below it, class cards show their first session, and a trial's Pay Now lands on the branded checkout (#1345, #1346, #1429) #1514, fix(booking): the allocator no longer declines the reschedule proposal it is confirming, and accept serialises on the appointment lock (#1340) #1515, this PR), written from each PR's merged/open body. Also fixes the stale "only surviving MANUAL_REVIEW path" sentence that feat(booking): cancellation terms are typed versioned rows with per-org tiers, and a credit-funded partial cancel restores the credit in full (#1499, #1500, #1372) #1513 obsoletes.

Files

• lib/maintenance-cron.ts
• app/api/cleanup/process-payouts/route.ts
• app/api/cleanup/sweep-abandoned-overage-charges/route.ts
• scripts/appointments/detect-consultant-no-shows.ts
• __tests__/maintenance/cron-lock-registry.test.ts
• __tests__/booking/no-show-refund-front-door.test.ts
• __tests__/maintenance/no-show-auto-complete-handoff.test.ts
• .claude/skills/booking/SKILL.md
• docs/booking/18-state-machines.md
• docs/booking/README.md
• docs/booking/13-cron-jobs-and-background-tasks.md
• docs/maintenance/04-cron-jobs-reference.md
• docs/booking/05-troubleshooting-and-changelog.md

Verification

Check	Result
rm tsconfig.tsbuildinfo && NODE_OPTIONS=--max-old-space-size=8192 npx tsc --noEmit (after rebase onto 01a377342)	exit 0, no errors
npx eslint on all 7 changed/new code files	0 problems
npx prettier --check on all 7 changed/new code files	clean
npx prettier --check on the 6 changed docs files	5 clean; docs/booking/18-state-machines.md was already Prettier-dirty on origin/dev (unpadded tables and a wrapped bullet outside the section I touched) and is left as-is per the existing project pattern (see #1514's note on the same posture); the lines I added are themselves Prettier-clean
npx jest __tests__/maintenance __tests__/booking __tests__/appointments (after rebase)	exit 0 — 87 suites, 1348 tests passed
Two suites mocked Prisma without $transaction (__tests__/booking/no-show-refund-front-door.test.ts, __tests__/maintenance/no-show-auto-complete-handoff.test.ts)	extended the mocks with $transaction, consultation.findUnique, and bookingStatusHistory.create rather than weakening any assertion

Not done

• None of the six numbered spec items were skipped.

Closes #1506
Part of #1338
Part of #1493
Part of #1420

🤖 Generated with Claude Code

https://claude.ai/code/session_01EyngsXG829TRTBof4CSGT1

[netlify]

✅ Deploy Preview for familiarise ready!

Name	Link
🔨 Latest commit	e5c4441
🔍 Latest deploy log	https://app.netlify.com/projects/familiarise/deploys/6a9ca12d621afa0008f4d5c3
😎 Deploy Preview	https://deploy-preview-1516--familiarise.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 30 (🔴 down 23 from production) Accessibility: 90 (no change from production) Best Practices: 83 (no change from production) SEO: 90 (🟢 up 8 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Warning

Review limit reached

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 90 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: e448a50f-b9a3-43c4-ab81-4c24efaa97dd

📥 Commits

Reviewing files that changed from the base of the PR and between eee250e and e5c4441.

📒 Files selected for processing (13)

• .claude/skills/booking/SKILL.md
• __tests__/booking/no-show-refund-front-door.test.ts
• __tests__/maintenance/cron-lock-registry.test.ts
• __tests__/maintenance/no-show-auto-complete-handoff.test.ts
• app/api/cleanup/process-payouts/route.ts
• app/api/cleanup/sweep-abandoned-overage-charges/route.ts
• docs/booking/05-troubleshooting-and-changelog.md
• docs/booking/13-cron-jobs-and-background-tasks.md
• docs/booking/18-state-machines.md
• docs/booking/README.md
• docs/maintenance/04-cron-jobs-reference.md
• lib/maintenance-cron.ts
• scripts/appointments/detect-consultant-no-shows.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[teetangh]

@coderabbitai full review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. Your current included review allowance is based on your included PR review attempts over the past 7 days. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 40 minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud