Skip to content

Vibe code --follow-symlinks #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Vibe code --follow-symlinks #5211

wants to merge 1 commit into from

Conversation

andyleejordan
Copy link
Member

Fix #5169.

@Copilot Copilot AI review requested due to automatic review settings June 10, 2025 20:14
@andyleejordan
Copy link
Member Author

Did it work?

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #5169 by updating the build and packaging scripts to always use symbolic links for the PSES modules.

  • Removed conditional handling for Debug and Release builds in the RestoreEditorServices task to enforce symlink usage.
  • Updated the package script in package.json to include the --follow-symlinks flag to support this change.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vscode-powershell.build.ps1 Removed the configuration-based switch and now always creates a symbolic link for PSES.
package.json Added the --follow-symlinks flag to ensure packaging respects symbolic links for modules.
Comments suppressed due to low confidence (2)

package.json:108

  • [nitpick] Consider updating the project documentation or release notes to explain the new '--follow-symlinks' flag and its impact on the packaging process.
    "package": "vsce package --out out/ --no-gitHubIssueLinking --follow-symlinks",

vscode-powershell.build.ps1:36

  • The removal of the configuration-specific switch is a significant change. Please confirm that always using a symbolic link for './modules' is intended and update the code comments or documentation to clarify this behavior.
    # Always use a symlink for ./modules pointing to PSES

@andyleejordan
Copy link
Member Author

This "vibe code" attempt was via the Copilot agent inside a pre-populated codespace for the issue, but now that it's enabled for the PowerShell GitHub organization, I'm having it re-attempt using "assign to Copilot agent" in #5212.

@andyleejordan andyleejordan marked this pull request as draft June 11, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Use --follow-symlinks in VSCE
1 participant