-
Notifications
You must be signed in to change notification settings - Fork 98
NuGet v3 populate dependencies #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NuGet v3 populate dependencies #1778
Conversation
I don't consider this WIP anymore. But maintainers who know more about the repositories used for testing might want to write some more tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR @o-l-a-v and for your effort here! My apologies for the delay in reviewing this. I'm approving it but making a note that we (the PSGet team) should open a follow up PR with tests and ensuring that when a package from v3 feed, has multiple dependency groups we only return unique dependencies if there are duplicates amongst the dependency groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a simple test for Install-PSResource and save-PSResource, thanks @o-l-a-v!
Co-authored-by: Anam Navied <[email protected]>
Co-authored-by: Anam Navied <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @o-l-a-v, due to Microsoft policies our CI tests can only run from a branch inside of PowerShell/PSResourceGet (ie it no longer can run from a fork). I pushed your branch and opened a PR to run tests (that PR is: #1836). There are some flakey tests but my main concern is with the GitHub Packages test because those paths run through the v3Server classes. |
PR Summary
What
Populate dependencies on NuGet v3 search.
-IncludeDependencies
for NuGet v3 repositories.Todo / not working: General NuGet packages support
NuGet Gallery packages can have multiple dependencyGroups where they are targeted to dotnet version. Example
azure.core
:This PR makes PSResourceGet just spit out all dependencies in all dependency groups. For
azure.core
this results in:Find-PSResource
Save-PSResource
Motivation
Better support for NuGet v3 repositories. My specific reasons:
Tested how
Tested with pwsh.gallery:
Example NuGet v3 data for Az v13.1.0 from pwsh.gallery
https://pwsh.gallery/registration/az/index.json
PR Context
In my testing so far I believe this PR fixes:
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.