Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also add launch configuration for windows #859

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Dec 17, 2024

Follow-up to #857

@mgovers mgovers added the improvement Improvement on internal implementation label Dec 17, 2024
@mgovers mgovers self-assigned this Dec 17, 2024
TonyXiang8787
TonyXiang8787 previously approved these changes Dec 17, 2024
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/launch-json-windows branch from 612fbb7 to 569d8aa Compare December 17, 2024 14:02
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@mgovers
Copy link
Member Author

mgovers commented Dec 18, 2024

merge queue failed probably due to windows github actions runners being down. rerunning the actions succeeded. attempting to merge again.

@mgovers mgovers added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit cce1408 Dec 18, 2024
28 checks passed
@mgovers mgovers deleted the feature/launch-json-windows branch December 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants