Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columnar data documentation (Terminology) #783

Merged
merged 12 commits into from
Oct 18, 2024
Merged

Conversation

nitbharambe
Copy link
Member

Fixes issue: `#548

The task of this issue is covered by this PR and by #781

Signed-off-by: Nitish Bharambe <[email protected]>
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@figueroa1395
Copy link
Contributor

@mgovers @nitbharambe Minor comment, but I believe you guys split this task into two (This and #781 PRs), could you in the description of each PR describe who is doing what, it is not clear to me. That way we are less prone to miss something if we know what is the content.

@mgovers
Copy link
Member

mgovers commented Oct 15, 2024

i renamed #781 to explicitly mention Python API docs. this PR is specifically about the dataset terminology.

@nitbharambe nitbharambe marked this pull request as ready for review October 16, 2024 07:17
docs/conf.py Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Show resolved Hide resolved
nitbharambe and others added 5 commits October 16, 2024 10:08
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking great, setting the bar high with the documentation. Awesome job.

docs/user_manual/dataset-terminology.md Show resolved Hide resolved
docs/user_manual/dataset-terminology.md Outdated Show resolved Hide resolved
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Copy link

sonarcloud bot commented Oct 16, 2024

@nitbharambe nitbharambe self-assigned this Oct 18, 2024
@mgovers mgovers enabled auto-merge October 18, 2024 11:58
@mgovers mgovers added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit eed5887 Oct 18, 2024
26 checks passed
@mgovers mgovers deleted the docs/columnar-data-terminology branch October 18, 2024 12:38
@mgovers mgovers mentioned this pull request Nov 5, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants