Feature/columnar dataset python extension #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
mgovers
changed the base branch from
main
to
feature/columnar-dataset-python-api
…set-python-extension Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
…set-python-extension
…set-python-extension
…set-python-extension
nitbharambe
reviewed
Sep 19, 2024
Signed-off-by: Nitish Bharambe <[email protected]>
|
When deserializing using an all columnar filter, the deserializer does not know what attributes are present in the given binary buffer. Hence buffers for all attributes are generated when Edit: Having empty columns is expected behavior |
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
nitbharambe
changed the base branch from
main
to
fix/columnar-convert-mutable-to-const-1
…olumnar-dataset-python-extension
Base automatically changed from
fix/columnar-convert-mutable-to-const-1
to
main
September 24, 2024 08:48
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Merged
…/columnar-dataset-python-mypy Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
…re/columnar-dataset-python-mypy Signed-off-by: Martijn Govers <[email protected]>
…python-mypy Add numpy to mypy check
figueroa1395
previously approved these changes
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
mgovers
dismissed
figueroa1395’s stale review
The merge-base changed after approval.
figueroa1395
previously approved these changes
Oct 1, 2024
mgovers
dismissed
figueroa1395’s stale review
The merge-base changed after approval.
figueroa1395
previously approved these changes
Oct 1, 2024
mgovers
dismissed
figueroa1395’s stale review
The merge-base changed after approval.
figueroa1395
previously approved these changes
Oct 1, 2024
mgovers
dismissed
figueroa1395’s stale review
The merge-base changed after approval.
figueroa1395
approved these changes
Oct 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the actual support for columnar dataset types in the Python API
Follow-up to #663