-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Check generated code #658
Conversation
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awaiting decision on the remaining comments. the rest LGTM
tip: try to change something and reproduce that the action indeed works as intended:
|
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. can you now do some commits to prove that indeed it works as intended? (e.g.:
- not run on formatting issues
- run and failing on changed template
- run and failing on change in generated file
- run and failing on change in code generator
- run and passing on all up to date (this should be the last commit to ensure the previous ones are all reset)
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
Signed-off-by: Santiago Figueroa <[email protected]>
maybe add an additional message, e.g.: Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/src/power_grid_model/core/dataset_definitions.py
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model_c/src/dataset_definitions.cpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model_c/include/power_grid_model_c/dataset_definitions.h
The following files are outdated or were manually updated:
M src/power_grid_model/core/dataset_definitions.py
Error: Process completed with exit code 1. into Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_gen/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/output.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/input.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/static_asserts/update.hpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/src/power_grid_model/core/dataset_definitions.py
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model_c/src/dataset_definitions.cpp
Generating file: /home/runner/work/power-grid-model/power-grid-model/power_grid_model_c/power_grid_model_c/include/power_grid_model_c/dataset_definitions.h
Error: The following files are outdated or were manually updated:
M src/power_grid_model/core/dataset_definitions.py
Error: Process completed with exit code 1. |
Signed-off-by: Santiago Figueroa <[email protected]>
Quality Gate passedIssues Measures |
Closes #527