Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRSE documentation #488

Merged
merged 14 commits into from
Feb 13, 2024
Merged

NRSE documentation #488

merged 14 commits into from
Feb 13, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Feb 7, 2024 •
edited
Loading

@mgovers mgovers self-assigned this Feb 7, 2024
@mgovers mgovers added the documentation Improvements or additions to documentation label Feb 7, 2024
@mgovers
initial setup NRSE documentation
ebffe28 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
add nrse documentation
17a7097 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/nrse-documentation branch from b0d0935 to 17a7097 Compare February 8, 2024 16:39
@mgovers
fix links
03fca21 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix typo
0e67c1a 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix typo
e828927 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix
e946bc5 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix
6354483 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
improve NRSE docs
143a097 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers marked this pull request as ready for review February 9, 2024 12:53
@mgovers
fix warning
fec2299 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
attempt use py:class
c665996 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix link
9e2d8b2 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
minor
8937c59 
Signed-off-by: Martijn Govers <[email protected]>
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Mostly suggestions on wording.

@Jerry-Jinfeng-Guo
Copy link
Contributor

Upon discussion with @TonyXiang8787 , the reviews are incorporated into the documentation and all related conversations are hereby resolved.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo merged commit 8590014 into main Feb 13, 2024
27 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/nrse-documentation branch February 13, 2024 14:59
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo restored the feature/nrse-documentation branch February 12, 2025 11:10
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/nrse-documentation branch February 12, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

@zhen0427 zhen0427 Awaiting requested review from zhen0427

Assignees

@mgovers mgovers

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @Jerry-Jinfeng-Guo @TonyXiang8787