-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental Y-Bus admittance matrix update #444
Incremental Y-Bus admittance matrix update #444
Conversation
… using `std::views` for now. ToDo: add test case / benchmark the perf diff; add implementation using `std::views`. Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…revent decrement more than once Signed-off-by: Jerry Guo <[email protected]>
… based `affected_entries`. Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i won't review everything but i just happened to find this 😬
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…on shortening Signed-off-by: Jerry Guo <[email protected]>
@Jerry-Jinfeng-Guo is this PR now out of draft and ready for review? |
@TonyXiang8787 To the comment : it's ready for review in its current usage. Some major discussions need to happen as to how users would typically use it, but I think those are mostly wrapper stuff on top of what's already implemented. |
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
… CASE; use `std::ranges` whenever possible. Signed-off-by: Jerry Guo <[email protected]>
…cache based increment; Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers @Jerry-Jinfeng-Guo before you guys merge, please change the name of the PR. The name of the PR will be in the release note, so make a more understandable and meaningful name. |
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
solved by making a callback if parameters changed that is registered for the solver to respective ybus |
Signed-off-by: Jerry Guo <[email protected]>
@Jerry-Jinfeng-Guo @mgovers is this ready for final review? |
Apart from a few code smells, yes |
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <[email protected]>
remaining code smells are the same as those on |
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_model.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
This is ready for review again |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
Incremental updates with decrement functionality, draft implementation not using
std::views
for now.: add test case / benchmark the perf diff; add implementation using
std::views
.