Clean-up main model: pass logger by reference to main model #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
4 tasks
… feature/log-less-main-model
Signed-off-by: Martijn Govers <[email protected]>
… feature/log-less-main-model
figueroa1395
previously approved these changes
Sep 9, 2025
There was a problem hiding this comment.
I am already approving... I think this change makes #1107 a lot cleaner and clearer.
nitbharambe
reviewed
Sep 9, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
|
No comments from me. I shall update the diagram in the end. Nice improvement! |
Base automatically changed from
feature/dependency-inversion-main-model-impl-info
to
main
September 9, 2025 14:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to see whether removing ownership of the
Logger* log_member variable ofMainModelImplmakes sense (cfr. #1107 (comment)).Relates to #1107 .