Convert Name field to string type #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
nitbharambe
reviewed
Sep 17, 2025
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
|
cfr. offline discussion: do-not-merge label added so that we do not accidentally merge on a friday |
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
nitbharambe
reviewed
Sep 24, 2025
Signed-off-by: Jerry Guo <[email protected]>
nitbharambe
previously approved these changes
Sep 24, 2025
nitbharambe
reviewed
Sep 24, 2025
nitbharambe
reviewed
Sep 24, 2025
Signed-off-by: Nitish Bharambe <[email protected]>
|
nitbharambe
approved these changes
Sep 24, 2025
nitbharambe
deleted the
feature/handle-large-number-in-extra-info-name-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
Namefields to string type to avoid scientific notations if the value is too big. Just a trial.