-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arrow example for columnar data #279
Conversation
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave update data creation up to users again or provide an example for that as well?
since this is only an example notebook, not a full feature, i don't think we need to add that. the only difference would be DatasetType.update
instead of DatasetType.input
sidenote: i see you add a lot of new cells. is there a need for that? or is it because you haven't removed the old ones yet?
Cells regarding decisions will be removed. The final example will be similar size as original. |
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
CI is failing on code quality |
Co-authored-by: Martijn Govers <[email protected]> Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
"id: int32\n", | ||
"u_rated: double\n", | ||
"-------asym load combined asym scehma-------\n", | ||
"-------asym load scehma-------\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-------asym load scehma-------\n", | |
"-------asym load schema-------\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did this end up in production? please do a follow-up PR to fix this. also double-check that there are no other typos like this remaining
Co-authored-by: Martijn Govers <[email protected]> Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of it looks good
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional nitpick: Although the section for batch data was not updated, I would still add a sentence reminding that it should be provided in columnar format to avoid zero copy (right?) and that it can also be validated. Just to be more self contained, but it is fine as is if you don't deem it necessary.
A lot more details can be mentioned about batch data, hence I chose not to mention any of them as it might appear incomplete :D In batch case, there would be multiple things to think about: |
Signed-off-by: Nitish Bharambe <[email protected]>
Quality Gate passedIssues Measures |
Changes proposed in this PR include:
Could you please pay extra attention to the points below when reviewing the PR:
Decisions
#TODO Decisions: Create from schema
# TODO Decisions: Asymmetric attributes should be fixed list array or individual phases or both?