Only run sonar cloud when PGM org is repo owner #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgovers
commented
Sep 3, 2024
Signed-off-by: Martijn Govers <[email protected]>
figueroa1395
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Sonar Cloud is only run when the PowerGridModel organisation is the repo owner.
This prevents cases like #272 in which an external contributor's PR is blocked by the fact that Sonar Cloud cannot run due to missing secrets.
Note that the line is also present in the power-grid-model repo in https://github.com/PowerGridModel/power-grid-model/blob/7e0645bf40cd4c8cacf023b6695f2811d889dd88/.github/workflows/sonar.yml#L76 .
This change was deliberately made via a fork to prove that it works as intended.