Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PGM mypy support #269

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Add PGM mypy support #269

merged 3 commits into from
Aug 21, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Aug 21, 2024

  • Follow-up to PGM mypy support
  • Fix not raising error when formatting not correct

@mgovers
add + resolve PGM mypy support
368ad60 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers added the improvement Existing functionality, but better, faster, stronger label Aug 21, 2024
@mgovers mgovers requested a review from nitbharambe August 21, 2024 12:07
@mgovers mgovers self-assigned this Aug 21, 2024
@mgovers
i can't test this fallback logic
706472b 
Signed-off-by: Martijn Govers <[email protected]>
mgovers
mgovers commented Aug 21, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
@mgovers mgovers enabled auto-merge August 21, 2024 12:23
@mgovers
resolve comment
acdc7b5 
Signed-off-by: Martijn Govers <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 3d21b95 Aug 21, 2024
25 checks passed
@mgovers mgovers deleted the feature/add-pgm-mypy-support branch August 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@mgovers mgovers

Labels
improvement Existing functionality, but better, faster, stronger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @nitbharambe