Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run citations workflow when current workflow changes + add concurrency check #246

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Apr 24, 2024

When PowerGridModel/power-grid-model#571 and #244 happened, we needed to manually run the citations validation check. This adds that and thereby also provides a template for similar actions that only need to happen when certain files change.

Proof that this change works: https://github.com/PowerGridModel/power-grid-model-io/actions/runs/8817491150/job/24203988223?pr=246

In addition, this action introduces the same github actions concurrency checks that the PGM repository has

We had to skip the python3.9 run on macos-latest due to the failure in https://github.com/PowerGridModel/power-grid-model-io/actions/runs/8816931897/job/24202179419?pr=246 which reads

Version 3.9 was not found in the local cache
Error: The version '3.9' with architecture 'arm64' was not found for macOS 14.4.1.
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@mgovers mgovers added the documentation Improvements or additions to documentation label Apr 24, 2024
@mgovers mgovers requested a review from petersalemink95 April 24, 2024 12:58
@mgovers mgovers self-assigned this Apr 24, 2024
@mgovers mgovers force-pushed the feature/run-citation-on-workflow-change branch from dd1afa6 to 36aa80c Compare April 24, 2024 13:09
mgovers added 2 commits April 24, 2024 15:34
Signed-off-by: Martijn Govers <[email protected]>
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 52592d2 Apr 24, 2024
32 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/run-citation-on-workflow-change branch April 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants