Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump power grid model to 1.6.x #196

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Bump power grid model to 1.6.x #196

merged 13 commits into from
Oct 6, 2023

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Oct 4, 2023

No description provided.

@mgovers mgovers added the improvement Existing functionality, but better, faster, stronger label Oct 4, 2023
@mgovers mgovers self-assigned this Oct 4, 2023
mgovers added 4 commits October 6, 2023 11:40
@mgovers
fix mypy pylint
cbcc3c3 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
resort entries test data
44d9e7e 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
update tests data
0688447 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
dump extra info
7008e70 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers changed the title first attempt at going to pgm-1.6.x Bump power grid model to 1.6.x Oct 6, 2023
mgovers added 2 commits October 6, 2023 12:11
@mgovers
remove deprecated TODO
11e2e51 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix pre-commit
9234238 
Signed-off-by: Martijn Govers <[email protected]>
mgovers
mgovers commented Oct 6, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
tests/data/pandapower/pgm_asym_output_data.json Outdated Show resolved Hide resolved
tests/data/pandapower/pgm_input_data.json Outdated Show resolved Hide resolved
tests/data/pandapower/pgm_output_data.json Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@mgovers mgovers marked this pull request as ready for review October 6, 2023 10:13
@mgovers
fix sonar cloud
ed81435 
DCO Remediation Commit for Martijn Govers <[email protected]>

I, Martijn Govers <[email protected]>, hereby add my Signed-off-by to this commit: a148355
I, Martijn Govers <[email protected]>, hereby add my Signed-off-by to this commit: bec331e

Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers linked an issue Oct 6, 2023 that may be closed by this pull request
[BUG] pre-commit configuration is very out of date and incompatible #197
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.4% 84.4% Coverage
0.0% 0.0% Duplication

@TonyXiang8787 TonyXiang8787 merged commit 085bd91 into main Oct 6, 2023
33 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/pgm-serializer branch October 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersalemink95 petersalemink95 petersalemink95 left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

@mgovers mgovers

Labels
improvement Existing functionality, but better, faster, stronger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] pre-commit configuration is very out of date and incompatible
3 participants
@mgovers @TonyXiang8787 @petersalemink95