Merge pull request #205 from PowerGridModel/fix/new-version-substitut…

…ion-status add substitution
PowerGridModel · Nov 29, 2023 · 0452a53 · 0452a53
2 parents 5b5a687 + 053fd7a
commit 0452a53
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/converters/tabular_converter.md b/docs/converters/tabular_converter.md
@@ -48,6 +48,7 @@ units:
 substitutions:
   ".*Switch state":
     "off": 0
+    "in": 1
     "on": 1
 ```
 
@@ -162,6 +163,7 @@ substitutions:
   ".*Switch state":
     "off": 0
     "in": 1
+    "on": 1
   N1:
     none: false
     own: true

diff --git a/src/power_grid_model_io/config/excel/vision_en.yaml b/src/power_grid_model_io/config/excel/vision_en.yaml
@@ -824,9 +824,11 @@ substitutions:
   ".*Switch state":
     "off": 0
     "in": 1
+    "on": 1
   "Switch state .*":
     "off": 0
     "in": 1
+    "on": 1
   N1:
     0: false
     1: true

diff --git a/tests/unit/mappings/test_value_mapping.py b/tests/unit/mappings/test_value_mapping.py
@@ -13,7 +13,7 @@ def mapping() -> ValueMapping:
     return ValueMapping(
         {
             "sources.closed": {"yes": 1, "no": 0},
-            ".*_switch_state": {"off": 0, "in": 1},
+            ".*_switch_state": {"off": 0, "in": 1, "on": 1},
             "N1": {"none": False, "own": True},
         }
     )
@@ -30,7 +30,7 @@ def test_get_substitutions__exact_match_with_table(mapping: ValueMapping):
 
 
 def test_get_substitutions__regex_match(mapping: ValueMapping):
-    assert mapping.get_substitutions("from_switch_state") == {"off": 0, "in": 1}
+    assert mapping.get_substitutions("from_switch_state") == {"off": 0, "in": 1, "on": 1}
 
 
 def test_get_substitutions__no_match(mapping: ValueMapping):