Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: improve downstream node performance #21

Merged
merged 40 commits into from
Feb 5, 2025

Conversation

Thijss
Copy link
Contributor

@Thijss Thijss commented Jan 29, 2025

Improve performance of grid.get_downstream_nodes
Also adds a get_downstream_nodes graph method

performance difference:
old
Screenshot 2025-02-05 at 15 32 33

new
Screenshot 2025-02-05 at 15 38 49

@Thijss Thijss force-pushed the feature/downstream_node_performance-V2 branch from 81b8d23 to 227598e Compare January 29, 2025 10:04
@Thijss Thijss force-pushed the feature/downstream_node_performance-V2 branch from 227598e to 6d791f5 Compare January 29, 2025 10:06
Thijss and others added 2 commits January 29, 2025 11:09
Co-authored-by: jaapschoutenalliander <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Co-authored-by: jaapschoutenalliander <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss changed the base branch from main to feat/update-performance-tests January 29, 2025 10:15
Base automatically changed from feat/update-performance-tests to main January 29, 2025 12:50
@Thijss Thijss marked this pull request as ready for review February 3, 2025 19:58
@Thijss Thijss changed the title Feature/downstream node performance v2 Feature/downstream node performance Feb 3, 2025
@Thijss Thijss changed the title Feature/downstream node performance Feat: improve downstream node performance Feb 3, 2025
Copy link
Contributor

@jaapschoutenalliander jaapschoutenalliander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, left my opionion on naming

src/power_grid_model_ds/_core/model/graphs/models/base.py Outdated Show resolved Hide resolved
tests/unit/model/grids/test_grid_search.py Outdated Show resolved Hide resolved
src/power_grid_model_ds/_core/model/graphs/models/base.py Outdated Show resolved Hide resolved
Thijss and others added 14 commits February 5, 2025 14:27
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss changed the base branch from main to feat/add-from-txt February 5, 2025 13:57
@Thijss Thijss changed the base branch from feat/add-from-txt to main February 5, 2025 14:29
@Thijss Thijss changed the base branch from main to feat/add-from-txt February 5, 2025 14:30
Co-authored-by: jaapschoutenalliander <[email protected]>

Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss changed the base branch from feat/add-from-txt to main February 5, 2025 14:41
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss enabled auto-merge (squash) February 5, 2025 14:51
@Thijss Thijss merged commit 7785db2 into main Feb 5, 2025
17 of 18 checks passed
@Thijss Thijss deleted the feature/downstream_node_performance-V2 branch February 5, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants