-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: improve downstream node performance #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaapschoutenalliander <[email protected]>
Signed-off-by: jaapschoutenalliander <[email protected]>
Signed-off-by: jaapschoutenalliander <[email protected]>
81b8d23
to
227598e
Compare
Signed-off-by: Thijs Baaijen <[email protected]>
227598e
to
6d791f5
Compare
Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
…node_performance-V2
Thijss
commented
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good solution, left my opionion on naming
…de_performance-V2
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Vincent Koppen <[email protected]>
Signed-off-by: Vincent Koppen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
vincentkoppen
approved these changes
Feb 5, 2025
jaapschoutenalliander
approved these changes
Feb 5, 2025
Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of
grid.get_downstream_nodes
Also adds a
get_downstream_nodes
graph methodperformance difference:
![Screenshot 2025-02-05 at 15 32 33](https://private-user-images.githubusercontent.com/13253091/410039305-d7a4e7f1-2094-42f9-a263-c63c2c2ad454.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTg3MTYsIm5iZiI6MTczOTU1ODQxNiwicGF0aCI6Ii8xMzI1MzA5MS80MTAwMzkzMDUtZDdhNGU3ZjEtMjA5NC00MmY5LWEyNjMtYzYzYzJjMmFkNDU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE4NDAxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzN2JlOTVlMGUxYjdlZGUyN2NmMWJlMDc5Yzk1M2Y0Zjg1YTk3NDFkYjQyZjEwZTQ5MDMxYTIwNWM2ZDlhNWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cR0ChUO3jv2khzs0QGglpCwtCZZZOb6WcE7ZO9PJ7CE)
old
new
![Screenshot 2025-02-05 at 15 38 49](https://private-user-images.githubusercontent.com/13253091/410039362-84d40922-ef35-4098-b3a7-c9c826e57a93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTg3MTYsIm5iZiI6MTczOTU1ODQxNiwicGF0aCI6Ii8xMzI1MzA5MS80MTAwMzkzNjItODRkNDA5MjItZWYzNS00MDk4LWIzYTctYzljODI2ZTU3YTkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE4NDAxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MGUyZjI1NjBlMWQ0ZGMxZjhmZjBlNGFlNDQ0NDJhOTZiYmM1MTJiMTE1ZjVhY2VlMjA2YWI0ZGJiNzFkMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4j8dLgYxbHjN0x66DvJ3bgR_6_VMMpO2akKdu2YuMdY)