fix: improve jwt errors #3933
Open
fix: improve jwt errors #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
reviewed
Mar 5, 2025
taimoorzaeem
force-pushed
the
fix/jwt-error
branch
4 times, most recently
from
9e3bc64 to
2069fe9
Compare
src/PostgREST/Auth.hs
Outdated
Comment on lines
74
to
77
| hasMin32Chars :: ByteString -> Either Error ByteString | ||
| hasMin32Chars token | ||
| | BS.length token >= 32 = Right token | ||
| | otherwise = Left $ JwtErr $ JwtDecodeError "JWT must be at least 32 characters" |
There was a problem hiding this comment.
Wasn't the jwt-secret the one that needed to be at least 32 chars? Not the JWT that's sent per request?
So isn't this unnecessary here?
There was a problem hiding this comment.
Hmm, now that I think of it, it is unnecessary. I just thought it would be a little nice to give this error, I'll remove it.
taimoorzaeem
force-pushed
the
fix/jwt-error
branch
2 times, most recently
from
77e3adb to
5a1c2a3
Compare
taimoorzaeem
force-pushed
the
fix/jwt-error
branch
from
5a1c2a3 to
4be7717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
We were exposing internal errors via
Show. This commit improves error messages for better user experience.Closes #3600, closes #3926.
I'll add docs once this design/change is approved.