Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: introduce admin-server-host config parameter #3558

Merged
merged 14 commits into from
Jun 24, 2024
Merged

config: introduce admin-server-host config parameter #3558

merged 14 commits into from
Jun 24, 2024

Conversation

develop7
Copy link
Collaborator

Introduces optional admin-server-host config setting, which falls back to server-host value

@develop7 develop7 marked this pull request as ready for review June 19, 2024 09:03
@develop7 develop7 changed the title Config: introduce admin-server-host config parameter config: introduce admin-server-host config parameter Jun 19, 2024
laurenceisla
laurenceisla reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@laurenceisla laurenceisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new config should be tested in test/io/db_config.sql alongside the non-reloadable configs.

Also needs tests for the no-default configs (check below).

test/io/configs/expected/no-defaults.config Outdated Show resolved Hide resolved
test/io/configs/no-defaults-env.yaml Outdated Show resolved Hide resolved
laurenceisla
laurenceisla approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@laurenceisla laurenceisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Show resolved Hide resolved
@laurenceisla laurenceisla merged commit 9d7e87b into PostgREST:main Jun 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenceisla laurenceisla laurenceisla approved these changes

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@steve-chavez steve-chavez steve-chavez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@develop7 @steve-chavez @wolfgangwalther @laurenceisla