-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump config through Admin API implementation #3193
Dump config through Admin API implementation #3193
Conversation
9be3ea8
to
459486f
Compare
@SkyWriter The direction looks good. Thanks for the contribution! We would need to add some tests. The Admin API uses python tests, you can get some inspiration from these: Lines 635 to 658 in 6682bae
Then you can run them locally with: $ nix-shell
$ postgrest-test-io
# you can also choose to run one test with
# $ postgrest-test-io -k name_of_test |
Network:.txt
<https://drive.google.com/file/d/1-aCTP_uWnR7DjNrDiYYLRw6kxpUB5Cyw/view?usp=drivesdk>
في الاثنين، ٢٩ كانون الثاني ٢٠٢٤, ١٠:٣٤ م Steve Chavez <
***@***.***> كتب:
… @SkyWriter <https://github.com/SkyWriter> The direction looks good.
Thanks for the contribution!
The Admin API uses python tests, you can get some inspiration from these:
https://github.com/PostgREST/postgrest/blob/6682baebd21253ebb851d8c58548982736bc0714/test/io/test_io.py#L635-L658
Then you can run them locally with:
$ nix-shell
$ postgrest-test-io
# you can also choose to run one test with# $ postgrest-test-io -k name_of_test
—
Reply to this email directly, view it on GitHub
<#3193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXQPHZW22P2BVYTB74BANKLYQ72SXAVCNFSM6AAAAABCOIZKRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGQZDCMBYHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
5d62080
to
dbd6220
Compare
@steve-chavez Thank you for the feedback. I think the PR is ready for review. "Loadtest / Loadtest PR (Nix) (pull_request)" automatic check is failing, but this seems to be rather just a CI issue. Let me know if you deem any changes are needed. Otherwise, thanks for running the wonderful project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! And yes, the loadtest failure is unrelated. Let's merge 🚀
This is a work-in-progress implementation of #3171.