Skip to content

feat(workflows): add the signals scout that produces suggestions #92252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmarchuk wants to merge 2 commits into from
+2,679 −380
Closed

feat(workflows): add the signals scout that produces suggestions #92252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9765937
feat(workflows): measure what an applied suggestion did
dmarchuk Sep 28, 2026
f8f8639
feat(workflows): add the signals scout that produces suggestions
dmarchuk Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions frontend/snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9745,29 +9745,29 @@ snapshots:
scenes-app-inbox-scoutwriteaccesstag--granted--light:
hash: v1.k794b7964.f43a37d7ad168d1f8b879e6361bf0cf88f1c492e176567a24f8919f7281cff27.WDlRZQnnmsRUqVgEm4VItfi-i3Dq86esxOUoRJ35jds
scenes-app-inbox-scoutwritescopespicker--cannot-edit--dark:
hash: v1.k794b7964.aae4e84a962f3c786854073627cfbde8817153c89f557d45e4f7bf51453efc08.uDiXXq6MHDMiFtfpbfl8Ttnk4P_w5FcGaRAywOn_yJM
hash: v1.k794b7964.3d7cc351c771192444675325ca1d45443f0ea667b24cdc40cee43e1d8d5d4891.pcN0bgekQ86aJMvuzsDuqoszvBWu03hiT6VRR1OsfTc
scenes-app-inbox-scoutwritescopespicker--cannot-edit--light:
hash: v1.k794b7964.ca38471ff1684bd45fd6657ca475af0a2d0f221330b0177f33c006e8d77d81f7.FUQltK-eW4ZY6xcajVySUBpA8F_UqFZUuk5QzLnZW70
hash: v1.k794b7964.86ad660d2128e555ec5693843e3b35adf031356a45a2ce42d78f7c17c9c35b9c._zn1LEIe1a84dMdbxZ8WOI1njFpBygz4VfuRrzgBhuA
scenes-app-inbox-scoutwritescopespicker--maintainer-scout--dark:
hash: v1.k794b7964.8c01f080b4e513d7796ee1d55e965afe96a7d90be130af7c90b8c831b230cf78.ol1ktS_KegTmrfuGT8FqI3v6G9f7yU2MsgM_IsmtWsM
hash: v1.k794b7964.290a8e966b8f9bf581fe70d4532c5f3a39d91e8d18bea63c248f08a2538ad893.BhMxwAts4gOn0kWI_qSahfRGATVNQL0xMXkzBQtdgY8
scenes-app-inbox-scoutwritescopespicker--maintainer-scout--light:
hash: v1.k794b7964.031cfbf2ea0907834c5316bfcc23db8fddcd4245c29b8c010bcd91d8fc8e3838.4QuBbOt2ZyVCLC6HWvxtQQIUiZCvjADStLynaak8uG0
hash: v1.k794b7964.732687ac09c81fce209162fcbf5ffbf3461302a729e1fb659c6ee4aa5f071423.v-TVOLWLoTiXvYiawpA1zR8wEe5JCySA2xQeSVKQS64
scenes-app-inbox-scoutwritescopespicker--read-only-scout--dark:
hash: v1.k794b7964.735429ab9b99d854d62be9adb3bea76ad7d10890f17c439f6a1eb47a9589e30c.K62jD4KDYLI4u1dU91tfpAuBr3wCZpVKMdbzSM-sBB4
hash: v1.k794b7964.ddd9736a49a506e3a58e15dc31428343fc030dbaf8e75d8e36979e6b5b2da6f1.yLtccme_H-N0c93wGRXRbz8G3n6B317KvZLZLURwHfE
scenes-app-inbox-scoutwritescopespicker--read-only-scout--light:
hash: v1.k794b7964.31e0d2baa63604ef23d1b5068455f8a333ed92d2ca56096b9bdae69812491378.PsEd-se0K5V9YBrfuJegX-05la9eBJxJYz1T-35LI6s
hash: v1.k794b7964.42d2173d6cc101637dcf60aaaf8c954d16520990b056bfd7f4112a76e11ca8f5.a8wdl3pfWi-05lq7jEFKgs7FLfOYiIEKQxd2HwQWdes
scenes-app-inbox-scoutwritescopespicker--scanner-maintainer-scout--dark:
hash: v1.k794b7964.8bd0a1d2775389213517ca32818323e6923f1598299df7818adf0b9594b8f764.9jnkfBZWLhyO5uPrslO_ijhszNOXSsRlAqTiUgN-U4Y
hash: v1.k794b7964.eca8e89bc049824be031704a4fbb849ae2788d5608d1fbbc1d3204042c2e566f.ENBca_snIC4AE3_Yz9jCzDsdG_h6-GoewTwa6ocCRJw
scenes-app-inbox-scoutwritescopespicker--scanner-maintainer-scout--light:
hash: v1.k794b7964.28584ca3974badfb3868e65c4b0af6f07387e37c109b1cf8c3f93e86725b1f9b.YghoWFN-lePYDzG_FbQc6fngIJ8x5MZsycjPGsTFLHg
hash: v1.k794b7964.bba3630699d9318fd499647ecc71c8fd25b31d3101513140bf1a2fd386a6794b.R7Mqh-xzAMHtI3Q8suBt-GEtNVu9Me0N2OdQeog5oPI
scenes-app-inbox-scoutwritescopespicker--scout-settings-variant--dark:
hash: v1.k794b7964.519e34f8fbd7eceb4843a1d0536b477dce4eae625b2997c865ff5c3f1c5ef356.-Of8pWWzx9pZZF4dDXsnR_sjP7pP9Oa5yIMwSUT_F5M
hash: v1.k794b7964.a358c16ec63a1134e88f7ede8f123be686f16980842d661392d36f8c9d7c578f.D6UpE2fKmirLj71sMp3iAGtJWROQ6Ow_CGCjzw687CY
scenes-app-inbox-scoutwritescopespicker--scout-settings-variant--light:
hash: v1.k794b7964.7984230dcb4f7f1011ad50790535ab38ad16cb1d85d98cce552b634b87f787d1.ataqN_IEJD0osVmvUtSElBKrQjQ65Ql4cjLq4DZI20Q
hash: v1.k794b7964.76f562d70a91c6177f32bc0188d564ecdaa1d167e7fce2cf41d71122106e72d2.aQwYVNfObr15qR3WilhwUxPydDnH-opv_xoB5sjJUxI
scenes-app-inbox-scoutwritescopespicker--with-granted-scopes--dark:
hash: v1.k794b7964.f4f2869c2ae34e94f0e4c4628c548a990e6ceb22f5ea96eb5867b098dc9f004f.jb4AVBHOujzfkgE-ZPW-TfCeKOe3t3jG0X3CqdNS1H8
hash: v1.k794b7964.7ad2e3a8214373bbfc42310e9d790e98242d402d1632fb2bb71f9d5c644d4d21.sBQORmA1SM03ZtQlXyOamx9n7aRiCgULG540u_U4r3M
scenes-app-inbox-scoutwritescopespicker--with-granted-scopes--light:
hash: v1.k794b7964.2dd74fab813b22724a00074e4b564fd131f976add8144d620670da70600b6511.ICZgVzVzMD7rdvIGfRR7HoKsMbp8uvKav294uYJlzuU
hash: v1.k794b7964.3a5555ea39b5cb407f3cdc3ab11848f0656195b2b8ecb0f52a74a8e2289a125d.ug5Oxi2SmxXv1Bem4kZz1HTovJzFpacK9NA34rRnMO0
scenes-app-inbox-selfdrivingsection--daily-limit-reached--dark:
hash: v1.k794b7964.4a44499b80e3b4929fae54d29924187253c3d56de5d4931e048e2d40f2a8fdbf._pm2YuKeybVX5dJoTbJTx9020tKZ9pl-Ygpdj5qX8jY
scenes-app-inbox-selfdrivingsection--daily-limit-reached--light:
Expand Down
4 changes: 4 additions & 0 deletions ...tion-3000/sidepanel/panels/access_control/ResourceAccessControlsV2/accessControlsLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -615,6 +616,7 @@
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -768,6 +770,7 @@
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -893,6 +896,7 @@
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1399,7 +1403,7 @@
actions.loadPanelEntry({ scopeType, subjectId })
},

saveGroupedRules: async ({ scopeType, scopeId, projectLevel, resourceLevels }) => {

Check warning on line 1406 in frontend/src/layout/navigation-3000/sidepanel/panels/access_control/ResourceAccessControlsV2/accessControlsLogic.ts

View workflow job for this annotation

GitHub Actions / Frontend formatting

lint:complexity 

`saveGroupedRules` has cyclomatic complexity 26 (warn >10)

Check warning on line 1406 in frontend/src/layout/navigation-3000/sidepanel/panels/access_control/ResourceAccessControlsV2/accessControlsLogic.ts

View workflow job for this annotation

GitHub Actions / Frontend formatting

lint:complexity 

`saveGroupedRules` has cyclomatic complexity 26 (warn >10)

Check warning on line 1406 in frontend/src/layout/navigation-3000/sidepanel/panels/access_control/ResourceAccessControlsV2/accessControlsLogic.ts

View workflow job for this annotation

GitHub Actions / Frontend formatting

lint:complexity 

`saveGroupedRules` has cyclomatic complexity 26 (warn >10)
// If the selected level equals the inherited level, we save null (clear override)
// If the selected level differs from inherited, we save it as an override

Expand Down
1 change: 1 addition & 0 deletions ...gation-3000/sidepanel/panels/access_control/ResourceAccessControlsV2/accessDetailLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ export interface accessDetailLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down
6 changes: 6 additions & 0 deletions ...0/sidepanel/panels/access_control/ResourceAccessControlsV2/addObjectOverrideModalLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export interface addObjectOverrideModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -233,6 +234,7 @@ export interface addObjectOverrideModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -377,6 +379,7 @@ export interface addObjectOverrideModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -505,6 +508,7 @@ export interface addObjectOverrideModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -632,6 +636,7 @@ export interface addObjectOverrideModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -780,6 +785,7 @@ export interface addObjectOverrideModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down
15 changes: 15 additions & 0 deletions ...anel/panels/access_control/ResourceAccessControlsV2/groupedAccessControlRuleModalLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export interface groupedAccessControlRuleModalLogicValues {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -207,6 +208,7 @@ export interface groupedAccessControlRuleModalLogicValues {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -328,6 +330,7 @@ export interface groupedAccessControlRuleModalLogicValues {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -462,6 +465,7 @@ export interface groupedAccessControlRuleModalLogicValues {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -596,6 +600,7 @@ export interface groupedAccessControlRuleModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -737,6 +742,7 @@ export interface groupedAccessControlRuleModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -858,6 +864,7 @@ export interface groupedAccessControlRuleModalLogicActions {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1018,6 +1025,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1141,6 +1149,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1263,6 +1272,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1385,6 +1395,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1508,6 +1519,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1630,6 +1642,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1763,6 +1776,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -1885,6 +1899,7 @@ export interface groupedAccessControlRuleModalLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/layout/navigation-3000/sidepanel/panels/access_control/accessControlLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ export interface accessControlLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
Comment thread
dmarchuk marked this conversation as resolved.
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -591,6 +592,7 @@ export interface accessControlLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down Expand Up @@ -713,6 +715,7 @@ export interface accessControlLogicMeta {
| 'health_issue'
| 'heatmap'
| 'hog_flow'
| 'hog_flow_proposal'
| 'hog_function'
| 'ingestion_warning'
| 'insight'
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/lib/scopes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ export const API_SCOPES_OMITTED_FROM_MODAL: Partial<Record<APIScopeObject, strin
batch_import_support: 'OAuth-hidden: staff-only, pasteable into a PAT but not advertised.',
query_performance: 'OAuth-hidden: staff-only, pasteable into a PAT but not advertised.',
wizard_session: 'OAuth-hidden: pasteable into a PAT but not advertised.',
// A per-scout grant: the workflows scout holds it through its config, so a person never pastes it.
hog_flow_proposal: 'Scout grant: held by the workflows scout through its config, not by a key.',
// Umbrella access-control resource that `warehouse_view`/`warehouse_table` inherit from —
// the granular scopes are offered instead, so keep the umbrella out of the modal.
warehouse_objects: 'Umbrella resource: grant warehouse_view/warehouse_table instead.',
Expand Down
1 change: 1 addition & 0 deletions frontend/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5918,6 +5918,7 @@ export const API_SCOPE_OBJECTS = [
'health_issue',
'heatmap',
'hog_flow',
'hog_flow_proposal',
'hog_function',
'ingestion_warning',
'insight',
Expand Down
Loading
Loading