Skip to content

chore(recording-api): fix aws error handling #64376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z0br0wn merged 2 commits into from
Jun 17, 2026
+5 −2
Merged

chore(recording-api): fix aws error handling #64376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62aa373
chore(recording-api): fix aws error handling
z0br0wn Jun 17, 2026
642c032
updates
z0br0wn Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodejs/src/session-replay/recording-api/recording-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class RecordingService {
)
return { ok: true, data: result }
} catch (error) {
if (error instanceof NoSuchKey) {
if (error instanceof NoSuchKey || (error as Error)?.name === 'NoSuchKey') {
logger.warn('[RecordingService] S3 object not found (NoSuchKey)', {
key,
teamId,
Expand Down
5 changes: 4 additions & 1 deletion nodejs/src/session-replay/shared/keystore/dynamodb-keystore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ export class DynamoDBKeyStore implements KeyStore {
})
)
} catch (error) {
if (error instanceof ConditionalCheckFailedException) {
if (
error instanceof ConditionalCheckFailedException ||
(error as Error)?.name === 'ConditionalCheckFailedException'
) {
// Key already exists — return the existing key instead of overwriting
return this.getKey(sessionId, teamId)
}
Expand Down
Loading