trunk-merge/pr-111480/b70b2560-5d28-4fe5-bd44-c0b0748ae3c0 - #111494
Closed
trunk-io[bot] wants to merge 3 commits into
Closed
trunk-io[bot] wants to merge 3 commits into
trunk-io[bot] wants to merge 3 commits into
Conversation
The play functions imported `within` from `storybook/test`. That copy of Testing Library ignores the 15s `asyncUtilTimeout` that preview.tsx sets, so `findByText` waited only 1s. On webkit under load, the root cause prompt renders after that, and MonitorRootCauseScoutForm fails. Import `within` from `@testing-library/dom` and `userEvent` from `@testing-library/user-event`, like most stories do. Generated-By: PostHog Desktop Task-Id: 06f2e6e0-d157-4a5d-be0e-b9ff9276ab93
The story file now imports `within` from `@testing-library/dom`. pnpm resolves only declared packages, so TypeScript could not find the module. Declare it as a peer dependency, as other product packages do. Generated-By: PostHog Desktop Task-Id: 06f2e6e0-d157-4a5d-be0e-b9ff9276ab93
Author
|
|
trunk-io
Bot
deleted the
trunk-merge/pr-111480/b70b2560-5d28-4fe5-bd44-c0b0748ae3c0
branch
October 4, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the master branch at SHA 39cc02e7c94212499e525d6a3786e7597592c35c.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 111480.