Skip to content

trunk-merge/pr-108162/1d6dd547-beb0-4a6d-a92a-4c724de0977f - #111089

Closed
trunk-io[bot] wants to merge 54 commits into
masterfrom
trunk-merge/pr-108162/1d6dd547-beb0-4a6d-a92a-4c724de0977f
Closed

trunk-merge/pr-108162/1d6dd547-beb0-4a6d-a92a-4c724de0977f#111089
trunk-io[bot] wants to merge 54 commits into
masterfrom
trunk-merge/pr-108162/1d6dd547-beb0-4a6d-a92a-4c724de0977f

Conversation

@trunk-io

@trunk-io trunk-io Bot commented Oct 2, 2026

Copy link
Copy Markdown
Trunk Merge Pull Request Banner

This pull request was created and is being managed by Trunk Merge.

This pull request is based on the master branch at SHA ff2ef488281784274ee89920cac25a8ac98da481.

See more details here.

When CI completes, this pull request will be closed automatically.

Pull Requests Being Tested

This pull request is testing the changes from pull request 108162, stacked on pull requests 108135 and 108161.

Dependencies

This pull request depends on the changes from pull requests 103604, 110759, 111013, 111035, 105242, and 110846.

posthog Bot and others added 30 commits September 21, 2026 10:09
@posthog
chore(tasks): split pure validation tests out of ai run defaults
813d51e 
TestValidateAIRunPreferences and TestRunCreateSerializerModeWithoutAdapter
assert only local validation, so they move to a database-free module.
TestRunCreateSerializerModeWithoutAdapter drops its unused APIBaseTest base.

Generated-By: PostHog Desktop
Task-Id: 94d388a3-1135-4b76-9501-fc5409164abe
@posthog
chore(tasks): drop the moved class from the database-free baseline
b6e0192 
TestRunCreateSerializerModeWithoutAdapter no longer inherits a database base
class, so the repo invariant no longer scans it as a candidate.

Generated-By: PostHog Desktop
Task-Id: 94d388a3-1135-4b76-9501-fc5409164abe
@sakce
feat(endpoints): materialize compare mode trends
5389a2f 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@sakce
Merge branch 'master' into posthog/materialized-endpoint-compare-mode
31aec30 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@sakce
fix(endpoints): harden compare materialization review fixes
c75e556 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@posthog
perf(endpoints): load version team in list querysets
1e9b5c7 
The materialization eligibility check reads the version's team for the compare-mode flag. The endpoint and version list querysets did not load that relation, so each unmaterialized row ran one extra query.

Select the team with the saved query, and run the list query-count tests for unmaterialized versions too.

Generated-By: PostHog Desktop
Task-Id: 33e1a67e-86fe-41e4-abd8-8cdea0bc16b9
@a-lider @claude
fix(endpoints): print the materialized preview as the request user
5bb9306 
The materialization preview resolved the materialized view with no user.
With warehouse access control on, a userless database denies every
warehouse view, so the preview returned no execution query.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@posthog
feat(web-analytics): rearrange tiles and keep them visible with a con…
54d5503 
…version goal

Put goals and session replay side by side, swap the geography and error tracking spots, and stop hiding error tracking, retention, goals, replay and frustrating pages when a conversion goal is selected.

Generated-By: PostHog Desktop
Task-Id: abbf5513-e42d-4241-834e-06d9282bab9b
@posthog
fix(web-analytics): keep geography full width without the v2 tile header
d2b2ec9 
Only the v2 grid packs densely, so a one-column geography tile left an empty gap on wide screens with the old tile header.

Generated-By: PostHog Desktop
Task-Id: abbf5513-e42d-4241-834e-06d9282bab9b
@posthog
fix(web-analytics): stack goals and replay full width on medium screens
da6e0e9 
At half width on the two-column grid, the goals tile is too narrow. Goals and replay now each use the full row at md, and stay side by side at 2xl.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: abbf5513-e42d-4241-834e-06d9282bab9b
@posthog
fix(web-analytics): keep error tracking tile unfiltered by conversion…
085c668 
… goal

The error tracking query reused the replay filter group, which carries the conversion goal as an action or event filter. Now that the tile stays visible with a goal, that silently narrowed the errors it showed. Build its filter group from the property filters only, and add a regression test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: abbf5513-e42d-4241-834e-06d9282bab9b
@posthog @mjwarren3
chore(visual): update storybook baselines
a7fd199 
6 updated
Run: b9029439-7b7a-44c7-b27c-d43be3aab2b6

Co-authored-by: mjwarren3 <37048138+mjwarren3@users.noreply.github.com>
@posthog
chore(web-analytics): fix lint and isolation in conversion goal tile …
5730424 
…test

Replace the disallowed toBeDefined assertion with toBeTruthy, and mock posthog.setPersonProperties in the block's setup so the test passes when it runs alone, not only after the compare filter block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: abbf5513-e42d-4241-834e-06d9282bab9b
@sakce
Merge branch 'master' into posthog/materialized-endpoint-compare-mode
946edd2 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@sakce
Merge branch 'master' into posthog/materialized-endpoint-compare-mode
50c64f8 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@sakce
fix(endpoints): avoid truncating materialized insights
98cf595 
Generated-By: PostHog Desktop
Task-Id: dfd25ee9-6919-4a87-a234-52175025275c
@sakce
chore(endpoints): fold materialized limit context assertion into brea…
9e8ce21 
…kdown test

The standalone test added one more outside test driving product_analytics'
query runners, which raised the model_crossing_uses baseline count and failed
the repo invariant. Asserting the limit context on the existing materialized
insight test keeps the count flat and covers the same regression.

Generated-By: PostHog Desktop
Task-Id: 7b226002-e454-4cd6-a37b-274f646f3489
@sakce
chore(endpoints): keep the compare rollout flag on for materialized r…
662b4d0 
…eads

Serving re-checks `can_materialize()` on every read, so the compare parity test
has to hold the rollout flag for the materialized read too — otherwise the read
falls back inline and the response carries no resolved compare date range.

`can_materialize_query` now evaluates the flag only when the query actually asks
for compare, keeping it off the read path of ordinary trends endpoints.

Generated-By: PostHog Desktop
Task-Id: 7b226002-e454-4cd6-a37b-274f646f3489
@mariusandra
fix(sql-editor): show loading state for saved insights
57c1edb
@mariusandra
chore: merge master into sql insight loading fix
c733b88
@mariusandra
chore(sql-editor): mock expressions in loading story
30d5a4e
@mariusandra
fix(sql-editor): highlight edited insights in the files tree
96fc737
@mariusandra
fix(sql-editor): capture loading state in storybook tests
0df4e49
@posthog @mariusandra
chore(visual): update storybook baselines
6ed00ba 
2 updated
Run: fda13555-5838-4378-b645-052699768e41

Co-authored-by: mariusandra <53387+mariusandra@users.noreply.github.com>
@sakce
Merge branch 'master' into posthog/materialized-endpoint-compare-mode
ce26139 
Generated-By: PostHog Desktop
Task-Id: 7b226002-e454-4cd6-a37b-274f646f3489
@a-lider @claude
fix(endpoints): bypass warehouse access when printing the preview
19bacfa 
The execution query preview is display-only text for the endpoint's own
materialized view and reads no rows, so it prints with the warehouse
bypass instead of a user-scoped context.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@pauldambra
Merge branch 'master' into posthog-self-driving/split-pure-ai-run-pre…
5d07d64 
…ference-tests-from-098275

Generated-By: PostHog Desktop
Task-Id: 591c4710-06f3-40d4-9de8-2f95d917f5c2
@pauldambra
fix(livestream): recheck current project membership
beab9ff 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
chore(livestream): use typed authorization test arguments
19964e4 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
fix(livestream): handle response close result
677d230 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
pauldambra and others added 24 commits October 2, 2026 19:26
@pauldambra
fix(livestream): harden periodic authorization checks
6a3e633 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
chore(livestream): simplify test authorization responses
6b18ca7 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
fix(livestream): keep notifications flowing during access checks
5591192 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
fix(livestream): record the token user on activity rows
dda6697 
LivestreamAuthentication now inherits ActivityCredentialMixin and declares the internal_jwt credential type. The repo invariant requires this of every authentication class.

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@pauldambra
fix(livestream): recheck verified-domain access
cffd665 
The live stream authorization endpoint now applies verified-domain enforcement to the token's organization. A member whose email is outside the verified domains loses the stream at the next periodic check, the same as on every other API view.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@pauldambra
fix(auth): reject ambiguous conversation widget tokens
e9c9c82 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
fix(api): reject non-object conversation settings
10da1c6 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
chore(api): type conversation validation cases
82e2fce 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
fix(api): document conversation settings object shape
40a71b2 
Generated-By: PostHog Desktop
Task-Id: 160dfc49-dceb-4887-b9f5-a93b2da017ed
@pauldambra
test(mcp): update unit test snapshots
83c5f07
@pauldambra
fix(api): handle legacy non-object conversations_settings on update
6a89e1f 
A team or project whose stored conversations_settings predates the object/null
validation can hold a stray array or scalar. Sending a valid object update
unpacked that value with `{**stored, **new}` and raised a 500. Treat a
non-dict stored value as empty before merging or diffing it, in both update
paths and the shared change-reporting helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@pauldambra
refactor: apply simplify pass
c3a91b9 
Move the legacy non-object conversations_settings check into one helper. The team update, project update and change reporting paths now share it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@pauldambra
fix(api): handle legacy conversations_settings when toggling widget
6bf4d7a 
A stored list, string or int in conversations_settings made a PATCH with conversations_enabled fail with a 500. The token handler read the raw value with .get() and dict(). It now uses the same dict coercion as the merge path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@pauldambra
fix(api): handle legacy conversations_settings in product enablement
d629d32 
Enabling conversations through product_enablement ran dict() on the stored value. A legacy string or int made it fail with a 500 before the save. It now uses the shared dict coercion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: c1760719-6011-4fd3-8a6c-96837fac0085
@trunk-io
Merging ce26139 into trunk-temp/pr-110759/c9896f17-93f8-43e5-a248-c9c…
7254587 
…989b52db5
@trunk-io
Merging 5d07d64 into trunk-temp/pr-110759/c9896f17-93f8-43e5-a248-c9c…
3476ae0 
…989b52db5
@trunk-io
Merging 96fc737 into trunk-temp/pr-111035/caf37e1f-e7d1-4a68-af11-74c…
2549140 
…c497e10e8
@trunk-io
Merging 6ed00ba into trunk-temp/pr-111035/caf37e1f-e7d1-4a68-af11-74c…
9a2a7a6 
…c497e10e8
@trunk-io
Merging 5730424 into trunk-temp/pr-111035/caf37e1f-e7d1-4a68-af11-74c…
544db91 
…c497e10e8
@trunk-io
Merging 3476ae0 into trunk-temp/pr-110846/0087bae5-aeeb-4fcb-b689-cf3…
a15161e 
…c751addf8
@trunk-io
Merging 19bacfa into trunk-temp/pr-110846/0087bae5-aeeb-4fcb-b689-cf3…
9e87bc3 
…c751addf8
@trunk-io
Merging 544db91 into trunk-temp/pr-108162/1d6dd547-beb0-4a6d-a92a-4c7…
98c594b 
…24de0977f
@trunk-io
Merging 9e87bc3 into trunk-temp/pr-108162/1d6dd547-beb0-4a6d-a92a-4c7…
db02cfb 
…24de0977f
@trunk-io
Merging d629d32 into trunk-temp/pr-108162/1d6dd547-beb0-4a6d-a92a-4c7…
00634f3 
…24de0977f
@trunk-io trunk-io Bot closed this Oct 2, 2026
@trunk-io
trunk-io Bot deleted the trunk-merge/pr-108162/1d6dd547-beb0-4a6d-a92a-4c724de0977f branch October 2, 2026 19:25
@trunk-io

trunk-io Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Scenes/Code review Default play-test The test failed because a logic component was not mounted when accessed, and there were unhandled network requests intercepted by the mock service... Logs ↗︎
Scenes-App/Feature Flags NewRemoteConfigFlagPayloadError play-test The test failed because the expected error message "Payload is required" was not visible on the page. Logs ↗︎
Scenes/Code review Default play-test A logic access error occurred because 'actions' on 'scenes.userLogic' was not mounted, likely due to missing logic connection or incorrect componen... Logs ↗︎
Scenes-App/Notebooks/Widget views InsightViews play-test The test failed because an expected value was not greater than or equal to 4, indicating a failed assertion or incorrect data condition. Logs ↗︎

... and 2 more

View Full Report ↗︎ ⋅ Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sakce @a-lider @mariusandra @pauldambra