chore(clickhouse): remove retired python migrations and hcl tooling - #111082
rorylshanks wants to merge 2 commits into
Conversation
🤖 CI report🚨 Trunk lane — universal laneThis PR is assigned to the universal lane. It cannot merge in parallel with other PRs, so it can take longer to merge. Ask dev-ex if you think this is wrong. ✅ Duplication (Python) — cleanNew Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. ✅ Duplication (TypeScript) — cleanNew TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. |
1293e13 to
4ae7b26
Compare
|
[High risk] Removes Python migration tooling and HCL schema system. The PR appears safe to merge, though the lost projection coverage and incorrect documentation references should be addressed. Reviews (1) · Last reviewed commit: 1293e13 |
| @@ -79,7 +85,7 @@ session_id_v7 UInt128, | |||
|
|
|||
There was a problem hiding this comment.
Schema guide cites nonexistent files
The updated guide points readers to catalog/events/columns.tf here and catalog/events/families.tf in the materialized-columns section, but neither file exists. The cited column and indexes are in catalog/events/main.tf. Point both references there so developers can find the examples.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/published/handbook/engineering/databases/clickhouse-queries-new-products.md
Line: 85
Comment:
**Schema guide cites nonexistent files**
The updated guide points readers to `catalog/events/columns.tf` here and `catalog/events/families.tf` in the materialized-columns section, but neither file exists. The cited column and indexes are in `catalog/events/main.tf`. Point both references there so developers can find the examples.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comments Outside DiffThese findings could not be posted inline.
|
4ae7b26 to
490911f
Compare
Problem
Maintainers can remove retired migration integrations after the new execution path is stable.
Changes
Deletes Python ClickHouse migrations, deployment-only DDL helpers, old HCL tooling and unused dependencies. Preserves runtime queries and SQL helpers required by isolated fixtures.
Rollout gate: Merge after cutover has been observed and infra ownership is complete. Pair final deletion with infra cleanup https://github.com/PostHog/posthog-cloud-infra/pull/10908. No schema DDL belongs in this layer. Merge bottom-first; do not land the whole stack together.
Before:
After:
How did you test this code?
Local catalogue validation and table-family checks passed, including the empty second plan.
posthog/clickhouse/test/test_managed_schema.py --reuse-dbpassed against local services. Python lint/format, lockfile and workflow checks passed. GitHub script tests passed with GNU sed, matching Linux CI; the pinned schema formatter passed. Live cloud rollout, the complete backend suite and both events-schema variants remain CI/review gates.Test rationale: The imported managed-schema regression checks reconstruction after fixture restore. Existing table-family checks validate the catalogue and require an empty second plan; no split-only tests were added.
Release status
Automatic notifications
Docs update
Updated the existing schema README and applicable schema-change guidance to describe this rollout stage.
🤖 Agent context
Autonomy: Human-driven (agent-assisted). Agent: Codex, GPT-6.
Staged replacement for #109937, which remains available for comparison. Source changes were split using Git, GitHub CLI and
gh stack; current master changes were retained. Skills: /stacking-prs, /writing-pr-descriptions, /running-ci-preflight, /authoring-ci-workflows, /clickhouse-migrations, /writing-tests, /writing-code-comments and /reviewing-with-coderabbit. Local CodeRabbit review was skipped at the directing user's request because the CLI was missing. No customer material was used. Human review and CI patch coverage are pending on this draft.