trunk-merge/pr-110809/b1e9cb61-77fd-445c-944e-276c35405c40 - #110953
Closed
trunk-io[bot] wants to merge 118 commits into
Closed
trunk-io[bot] wants to merge 118 commits into
trunk-io[bot] wants to merge 118 commits into
Conversation
Rebuild the BI worksheet around a Tableau-style layout: a data pane of dimensions and measures, filters and marks cards, rows and columns pill shelves above the view, a "Show me" chart picker, and a toolbar with swap, quick sort, and auto-update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The button opened the Fundamentals tab, which is behind the METRICS_FUNDAMENTALS flag. Without the flag, the scene fell back to the overview tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 5a2b9f43-13fb-4aca-b9f3-a249aa554c8d
Removes the Fundamentals tab, its logic, the /metrics/explain/ action with its diagnostics and fundamentals modules, the metrics-fundamentals flag constants, and the MCP tool entry. Regenerates the API types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 5a2b9f43-13fb-4aca-b9f3-a249aa554c8d
Generated-By: PostHog Desktop Task-Id: 5a2b9f43-13fb-4aca-b9f3-a249aa554c8d
The facade checks globbed facade/*.py, so a class leak or a Django type in facade/destinations/s3.py went unreported while the same code in a flat module failed lint. The walk is now recursive and findings are keyed by the module's path inside facade/ (destinations/s3.py). Flat modules keep their file name, so the existing ledger rows do not change. Relative imports in a nested module resolve against its own package, not facade/. Name exemptions (contracts.py, enums.py, testing.py, api*, capability stems) stay top-level only, so a nested destinations/contracts.py gets every check. Content rules apply at any depth. The import-linter globs are untouched.
_wiring_location_exports still globbed facade/*.py, so a lazy re-export map in a facade subfolder that points into a wiring location was not tracked as an export of that location. It now walks the same modules as the facade checks. The package_parts defaults on _iter_handed_out_names and _facade_import_env are gone. Every caller passes it, and a default would let a future caller resolve a nested module's relative imports against facade/ without notice.
Direct-mint sites each built an OAuthAccessToken row by hand: generate the token value, compute expiry from now, set scope and team pinning. Copies of security-sensitive code drift, and new callers (WebMCP is next) would add one more. `mint_oauth_access_token` in posthog/models/oauth.py now owns that, next to the model and the other token lookups, so products can import it without reaching into posthog.temporal. - Move the sandbox/wizard run mint in posthog/temporal/oauth.py and both streamlit_apps mints (iframe and bridge) onto the helper. - No behavior change: same token format, scope strings, lifetimes and scoped_teams; sandbox_task_id stays null where it was not set. - Leave the authorization-code/refresh flows (oauth views, agentic and Stripe provisioning, Stripe integration, generate_stripe_app_tokens) alone. They pair the access token with a refresh token, rotate rows, or take values from oauthlib, so they stay explicit.
The wiring export check turned every lazy-map source into a .py path. A source that names the wiring package (products.acme.backend.temporal) became backend/temporal.py, which sits outside backend/temporal/, so the export was dropped and a test importing it through the facade got no wiring origin. The check now accepts the package directory or the .py file.
The recursive facade walk filtered test modules by file name only, so a helper under facade/<sub>/tests/ or a nested conftest.py was read as public facade code and could fail product:lint. The filter now matches the crossings scanner: any test/ or tests/ path component, test_*.py, *_test.py and conftest.py.
Skipping every path under a test/ or tests/ folder let a leaking facade module escape all facade checks by moving into such a folder. A false positive on a test helper placed inside facade/ is the cheaper failure: test helpers belong outside the facade. The filter goes back to file names (test_*.py, *_test.py). This reverts commit 75f0462.
A leaking module moved into facade/<sub>/tests/ must still fail the facade checks, so a later directory-based test filter cannot reopen the blind spot.
2 updated Run: 92718009-080f-48a1-bb19-8fc805c612cd Co-authored-by: mariusandra <53387+mariusandra@users.noreply.github.com>
The canvas runtime now sends the client rect of the clicked highlight line with comment-activate. The field is optional, so builds made before this change stay valid. The web host moves the rect into page coordinates and passes it to onCommentActivate. The web sandbox document is regenerated from the runtime source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: b999fc3e-c145-4e0e-9851-6ef273201d04
A click on a highlight opens the thread in a popover at that line. A new comments menu in the canvas header lists every thread. The Comments side panel tab is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: b999fc3e-c145-4e0e-9851-6ef273201d04
A click on a text highlight or an image pin opens the thread in a popover next to it. The comments button opens a menu with comments on the whole file and a list of every thread. The comments side panel is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: b999fc3e-c145-4e0e-9851-6ef273201d04
Add products/autoresearch/backend/** to the selfDriving container-image path filter, and keep it in generalPurpose while both workers register autoresearch. Include the clipped capture error_description in the InferenceRunError for a failed or partial prediction emit, so a transport failure records the underlying exception text. Closes #110837 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 738aed62-67b4-4867-adb2-40a71130ad17
CI runs Kea typegen and then checks for a clean tree. The hand-written activateThread type used CanvasRect where typegen writes the object shape, so the schema diff checks failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: b999fc3e-c145-4e0e-9851-6ef273201d04
trunk-io
Bot
deleted the
trunk-merge/pr-110809/b1e9cb61-77fd-445c-944e-276c35405c40
branch
October 2, 2026 16:00
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the master branch at SHA 662ed11756653c2f52b855a01ee19a0c13b23faa.
See more details about each PR in the batch here:
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing a batch with the changes from pull requests 110809, 110796, 108101, and 110576 - batching documentation.
Pull request 108101 is stacked on pull requests 108099 and 108100, whose changes are included here and will be merged with it.
Dependencies
This pull request depends on the changes from pull requests 110856, 110579, 110905, 110273, 110906, 110347, 110601, 110801, 110830, 110789, 110415, 110160, 110577, 110908, and 108850.