Skip to content

trunk-merge/pr-110527/69864ddb-d895-4b7a-86e8-90ae064c2928 #110532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trunk-io wants to merge 3 commits into from
Closed

trunk-merge/pr-110527/69864ddb-d895-4b7a-86e8-90ae064c2928 #110532

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02bcd3c
chore(today): pin the clock in the first-open briefing test
aspicer Oct 2, 2026
5b5a95b
test(today): cover a call without a timezone on a different briefing day
aspicer Oct 2, 2026
70ebb1b
Merging 5b5a95b3b43d4dd4a59b999a0408d72e25008e1d into trunk-temp/pr-1…
trunk-io[bot] Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion products/today/backend/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def test_no_briefing_and_no_row_for_people_who_may_not_get_one(

def test_first_open_creates_one_briefing_and_starts_generation_once(self, sync_connect: MagicMock) -> None:
sync_connect.return_value.start_workflow = AsyncMock()
with self._flag(True):
# At noon UTC it is past eight in Prague and in the project's UTC, so both calls read the same briefing day.
with self._flag(True), time_machine.travel(datetime(2026, 9, 30, 12, 0, tzinfo=UTC), tick=False):
first = self.client.get(f"/api/projects/{self.team.id}/today/briefing/?timezone=Europe/Prague")
# An MCP call sends no timezone; it must not move the person's mornings to the project's.
second = self.client.get(f"/api/projects/{self.team.id}/today/briefing/")
Expand Down Expand Up @@ -87,10 +88,13 @@ def test_the_briefing_day_starts_at_eight(self, sync_connect: MagicMock) -> None
early = self.client.get(url).json()
with time_machine.travel(datetime(2026, 9, 30, 7, 0, tzinfo=UTC), tick=False):
today = self.client.get(url).json()
# A call without a timezone uses the project's UTC, where it is still before eight.
without_timezone = self.client.get(f"/api/projects/{self.team.id}/today/briefing/").json()

assert early["local_day"] == "2026-09-29"
assert today["local_day"] == "2026-09-30"
assert early["id"] != today["id"]
assert without_timezone["id"] == early["id"]
assert sync_connect.return_value.start_workflow.call_count == 2

def test_a_refresh_while_one_is_being_written_starts_nothing_new(self, sync_connect: MagicMock) -> None:
Expand Down
Loading