trunk-merge/pr-110220/45c5d137-71d7-42ea-b845-682127efcae5 - #110277
trunk-io[bot] wants to merge 2 commits into
Conversation
Neon 1.1 calls napi_delete_async_work inside debug_assert_eq! in its async-work completion callback. A release build drops that call, so every cx.task() in the replay-anonymizer addon left its async work alive. Each one keeps two V8 global handles: its resource object and the async context frame that was active at the call. With OpenTelemetry on, that frame holds the step's tracing context, so the ML mirror heap grew with every anonymized message until the pod restarted. The release profile now builds Neon with debug assertions, so the delete runs. A test checks that the async context of a finished call can be collected. Only a release build of the addon can fail it, and CI builds the addon in release mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PostHog/posthog/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe Neon release profile now enables debug assertions. A new native anonymizer test performs 20 calls in separate async-local stores, then checks that the stores are collectible after garbage collection. The test throws if the native addon cannot load in CI and skips with a warning otherwise. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The release configuration enables Neon cleanup assertions, and the regression test is integrated into CI. No actionable merge-blocking risk remains beyond normal build and test checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is intended to improve cleanup after anonymization without adding access or changing data contracts. Risk is low, but cleanup and failure behavior during interruption and shutdown are not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
Full details: Description checkExplanation The description only contains Trunk Merge metadata and does not explain the problem, changes, testing, test rationale, release status, notifications, docs impact, or agent context required by the repository template. Resolution Replace or supplement the Trunk Merge metadata with a completed repository-template description. Describe the Neon release-build issue, the native anonymizer test, how the changes were tested, the test rationale, release-status selection, docs and changelog decisions, and the required agent context.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
1 participant
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the master branch at SHA 3d99563a1be0535d4c0244363d3c8e3fa5aabf79.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 110220.