fix(flags): surface real errors in the flag testing tab - #108975
trunk-io[bot] merged 5 commits into
Conversation
- Accept a blank condition variant in the test evaluation response serializer. It failed validation and fell into the generic 500. - Return specific errors when the flags service is unreachable (503), rejects the request (400), or fails (502). Retry one connection reset. - Read the `error` field in evaluationErrorMessage, so the friendly rewrites match backend errors. - Validate groups and timestamp before the loaders run, so invalid input sets testError and does not go to error tracking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 1c61883c-4d71-4872-8504-7cafa662900a
|
😎 Merged successfully - details. |
🤖 CI report
|
| Function | Location | Complexity | Limit |
|---|---|---|---|
FeatureFlagTestingTab |
frontend/src/scenes/feature-flags/FeatureFlagTestingTab.tsx:70 |
33 | 10 |
✅ Duplication (Python) — clean
New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.
✅ Duplication (TypeScript) — clean
New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.
⚠️ Comment density — 5% of added code lines are comments (17 of 350)
This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.
Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.
Files with the most added comment lines:
| File | Comment lines | Added lines |
|---|---|---|
frontend/src/scenes/feature-flags/featureFlagTestingLogic.ts |
9 | 47 |
products/feature_flags/backend/api/feature_flag.py |
6 | 79 |
frontend/src/scenes/feature-flags/featureFlagTestingLogic.test.ts |
2 | 83 |
This check does not block merging. It updates on every push and clears when the share drops.
ℹ️ Bundle size — no base branch to compare
Uncompressed size of every built .js bundle, compared against the base branch.
Total: 70.24 MiB (no base branch measurement to compare against yet)
Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report
✅ Eager graph — within budget
How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.
| Root | Eager (shipped) | Δ vs base | Budget |
|---|---|---|---|
entry (logged-out pages, app bootstrap)src/index.tsx |
1.62 MiB · 22 files | (no base measurement) | █████████░ 87.8% of 1.84 MiB |
logged-out boot: index + App + bootApp (preloaded by every page, including /login)src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts |
3.57 MiB · 630 files | (no base measurement) | █████████░ 88.7% of 4.03 MiB |
authenticated shell (every logged-in page)src/scenes/AuthenticatedShell.tsx |
7.75 MiB · 2,486 files | (no base measurement) | █████████░ 92.9% of 8.34 MiB |
🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
Largest files eagerly shipped from src/index.tsx
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/index.tsx |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 854 B | src/scenes/ChunkLoadErrorBoundary.tsx |
Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
| Size | File |
|---|---|
| 306.2 KiB | ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs |
| 219.9 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 100.5 KiB | src/lib/api.ts |
| 91.9 KiB | src/products.tsx |
| 69.4 KiB | src/lib/lemon-ui/icons/icons.tsx |
| 40.1 KiB | src/lib/utils/eventUsageLogic.ts |
| 38.7 KiB | ../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js |
| 33.9 KiB | ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js |
| 28.6 KiB | src/scenes/scenes.ts |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 306.2 KiB | ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs |
| 279.9 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 219.9 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 153.7 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 109.9 KiB | ../packages/quill/packages/quill/dist/index.js |
| 100.5 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 91.9 KiB | src/products.tsx |
| 90.6 KiB | ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Toolbar bundle — eager 2.19 MiB within budget
What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.
| Metric | Size | Δ vs base | Budget |
|---|---|---|---|
| Eager (shipped) entry + static imports |
2.19 MiB · 19 files | (no base measurement) | ████░░░░░░ 38.3% of 5.72 MiB |
| Deferred (lazy) | 2.10 MiB · 44 files | (no base measurement) | n/a — loads on demand |
Loader dist/toolbar.js |
1.2 KiB | (no base measurement) | █░░░░░░░░░ 6.0% of 19.5 KiB |
Largest eagerly-shipped chunks
| Size | File |
|---|---|
| 828.7 KiB | dist/toolbar/toolbar-app-JMWOYNWY.css |
| 656.9 KiB | dist/toolbar/chunk-chunk-HCJ6OHTE.js |
| 259.4 KiB | dist/toolbar/chunk-chunk-TUDDG3HU.js |
| 138.2 KiB | dist/toolbar/chunk-chunk-DJSGW5RR.js |
| 131.8 KiB | dist/toolbar/chunk-chunk-FDH2IBXT.js |
| 75.2 KiB | dist/toolbar/toolbar-app-U3GEO6MT.js |
| 69.0 KiB | dist/toolbar/chunk-chunk-TSAL54PB.js |
| 35.6 KiB | dist/toolbar/chunk-chunk-LB3WNQSR.js |
| 21.0 KiB | dist/toolbar/chunk-chunk-J6LZJAFQ.js |
| 6.8 KiB | dist/toolbar/chunk-chunk-DV7IWQNF.js |
Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile
ℹ️ Dist folder size — no base branch to compare
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 964.84 MiB (no base branch measurement to compare against yet)
ℹ️ MCP UI apps size — 33 app(s), 17633.1 KB JS
Built size of each MCP UI app (main.js + styles.css).
| App | JS | CSS |
|---|---|---|
| debug | 597.9 KB | 199.3 KB |
| action | 454.1 KB | 199.3 KB |
| action-list | 564.2 KB | 199.3 KB |
| cohort | 453.1 KB | 199.3 KB |
| cohort-list | 563.2 KB | 199.3 KB |
| email-template | 452.9 KB | 199.3 KB |
| error-details | 469.6 KB | 199.3 KB |
| error-issue | 454.5 KB | 199.3 KB |
| error-issue-list | 564.8 KB | 199.3 KB |
| experiment | 561.3 KB | 199.3 KB |
| experiment-list | 564.9 KB | 199.3 KB |
| experiment-results | 566.3 KB | 199.3 KB |
| feature-flag | 566.8 KB | 199.3 KB |
| feature-flag-list | 570.5 KB | 199.3 KB |
| feature-flag-testing | 457.3 KB | 199.3 KB |
| inline-scan | 453.6 KB | 199.3 KB |
| insight-actors | 562.3 KB | 199.3 KB |
| invite-email-preview | 452.3 KB | 199.3 KB |
| llm-costs | 559.3 KB | 199.3 KB |
| session-recording | 455.3 KB | 199.3 KB |
| survey | 454.7 KB | 199.3 KB |
| survey-global-stats | 561.9 KB | 199.3 KB |
| survey-list | 564.9 KB | 199.3 KB |
| survey-stats | 561.9 KB | 199.3 KB |
| trace-span | 453.5 KB | 199.3 KB |
| trace-span-list | 564.1 KB | 199.3 KB |
| vision-observation-list | 563.3 KB | 199.3 KB |
| workflow | 453.4 KB | 199.3 KB |
| workflow-list | 563.5 KB | 199.3 KB |
| loops-review | 457.8 KB | 199.3 KB |
| query-results | 774.1 KB | 199.3 KB |
| render-ui | 858.1 KB | 199.3 KB |
| visual-review-snapshots | 457.9 KB | 199.3 KB |
✅ Backend coverage — all changed backend lines covered
🧪 Backend test coverage
Patch coverage — changed backend lines (products + core): ████████████████████ 100.0% (64 / 64)
All changed backend lines are covered ✅
Per-product line coverage (touched products)
| Product | Coverage | Lines |
|---|---|---|
platform_features |
██░░░░░░░░░░░░░░░░░░ 12.1% |
7 / 58 |
demo |
███████████░░░░░░░░░ 53.4% |
1,445 / 2,707 |
data_tools |
████████████░░░░░░░░ 61.2% |
90 / 147 |
warehouse_sources_queue |
█████████████░░░░░░░ 65.9% |
1,611 / 2,446 |
ai_gateway |
███████████████░░░░░ 75.0% |
9 / 12 |
aeo |
███████████████░░░░░ 76.3% |
617 / 809 |
batch_exports |
████████████████░░░░ 81.2% |
21,571 / 26,551 |
apm |
█████████████████░░░ 84.1% |
1,306 / 1,553 |
cdp |
██████████████████░░ 88.3% |
4,559 / 5,164 |
ml_inference |
██████████████████░░ 88.8% |
539 / 607 |
mcp_analytics |
██████████████████░░ 89.2% |
5,038 / 5,651 |
product_tours |
██████████████████░░ 89.3% |
1,340 / 1,500 |
dashboards |
██████████████████░░ 89.6% |
6,924 / 7,727 |
notebooks |
██████████████████░░ 90.2% |
15,304 / 16,971 |
data_warehouse |
██████████████████░░ 90.3% |
14,298 / 15,839 |
signals |
██████████████████░░ 90.3% |
59,285 / 65,644 |
cohorts |
██████████████████░░ 90.5% |
8,534 / 9,434 |
streamlit_apps |
██████████████████░░ 90.8% |
2,684 / 2,956 |
managed_warehouse |
██████████████████░░ 91.0% |
10,252 / 11,263 |
data_modeling |
██████████████████░░ 91.2% |
10,562 / 11,584 |
tasks |
██████████████████░░ 91.3% |
78,937 / 86,495 |
exports |
██████████████████░░ 91.7% |
9,684 / 10,566 |
today |
██████████████████░░ 91.8% |
1,034 / 1,126 |
business_knowledge |
██████████████████░░ 92.0% |
8,446 / 9,180 |
engineering_analytics |
██████████████████░░ 92.1% |
11,458 / 12,436 |
ai_training |
██████████████████░░ 92.2% |
356 / 386 |
conversations |
███████████████████░ 92.6% |
29,137 / 31,466 |
early_access_features |
███████████████████░ 92.6% |
1,339 / 1,446 |
managed_migrations |
███████████████████░ 92.7% |
1,581 / 1,705 |
stamphog |
███████████████████░ 92.8% |
8,109 / 8,742 |
visual_review |
███████████████████░ 92.9% |
9,534 / 10,265 |
canvas |
███████████████████░ 92.9% |
7,155 / 7,703 |
approvals |
███████████████████░ 93.0% |
3,974 / 4,271 |
mcp_registry |
███████████████████░ 93.1% |
1,670 / 1,794 |
notifications |
███████████████████░ 93.2% |
1,144 / 1,228 |
error_tracking |
███████████████████░ 93.2% |
16,368 / 17,555 |
surveys |
███████████████████░ 93.4% |
6,644 / 7,113 |
slack_app |
███████████████████░ 93.6% |
14,560 / 15,557 |
autoresearch |
███████████████████░ 93.6% |
8,837 / 9,442 |
context_layer |
███████████████████░ 93.8% |
3,415 / 3,639 |
web_analytics |
███████████████████░ 93.9% |
23,680 / 25,229 |
billing_alerts |
███████████████████░ 94.1% |
2,094 / 2,226 |
mcp_store |
███████████████████░ 94.3% |
8,959 / 9,501 |
ai_observability |
███████████████████░ 94.6% |
24,974 / 26,409 |
alerts |
███████████████████░ 94.6% |
9,267 / 9,796 |
wizard |
███████████████████░ 94.7% |
6,150 / 6,496 |
workflows |
███████████████████░ 94.7% |
15,159 / 16,006 |
reminders |
███████████████████░ 94.8% |
760 / 802 |
review_hog |
███████████████████░ 95.0% |
11,623 / 12,235 |
annotations |
███████████████████░ 95.1% |
817 / 859 |
endpoints |
███████████████████░ 95.1% |
9,222 / 9,694 |
customer_analytics |
███████████████████░ 95.2% |
25,991 / 27,301 |
legal_documents |
███████████████████░ 95.2% |
2,311 / 2,427 |
posthog_ai |
███████████████████░ 95.3% |
2,491 / 2,614 |
marketing_analytics |
███████████████████░ 95.3% |
19,598 / 20,559 |
actions |
███████████████████░ 95.5% |
756 / 792 |
logs |
███████████████████░ 95.5% |
15,468 / 16,200 |
experiments |
███████████████████░ 95.5% |
32,931 / 34,481 |
data_catalog |
███████████████████░ 95.5% |
4,401 / 4,606 |
tracing |
███████████████████░ 95.6% |
3,536 / 3,699 |
replay_vision |
███████████████████░ 95.6% |
29,078 / 30,404 |
growth |
███████████████████░ 95.7% |
11,381 / 11,888 |
skills |
███████████████████░ 95.8% |
6,972 / 7,274 |
messaging |
███████████████████░ 95.9% |
3,824 / 3,989 |
product_analytics |
███████████████████░ 96.0% |
28,521 / 29,696 |
revenue_analytics |
███████████████████░ 96.4% |
1,889 / 1,959 |
access_control |
███████████████████░ 96.5% |
7,246 / 7,512 |
user_interviews |
███████████████████░ 96.5% |
2,870 / 2,974 |
feature_flags |
███████████████████░ 96.6% |
26,809 / 27,748 |
warehouse_sources |
███████████████████░ 97.3% |
468,087 / 480,989 |
data_quality |
████████████████████ 97.5% |
7,701 / 7,895 |
links |
████████████████████ 97.9% |
234 / 239 |
security |
████████████████████ 98.0% |
1,283 / 1,309 |
metrics |
████████████████████ 98.0% |
4,245 / 4,331 |
analytics_platform |
████████████████████ 98.3% |
2,784 / 2,833 |
pulse |
████████████████████ 98.5% |
2,046 / 2,078 |
live_debugger |
████████████████████ 99.2% |
626 / 631 |
field_notes |
████████████████████ 99.4% |
172 / 173 |
Report-only. Patch coverage = changed backend lines covered vs origin/master. Sorted lowest first.
Known gaps: lines covered only by Temporal tests show as uncovered; core line numbers may drift if master changed the same file.
github-actions
Bot
added
feature/feature-flags
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 1c61883c-4d71-4872-8504-7cafa662900a
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PostHog/posthog/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe frontend now validates feature-flag test input before starting single-ID or batch evaluation and formats evaluation errors. The backend validates groups, accepts blank condition variants, retries the flags-service request once, and maps serializer, connection, timeout, and upstream HTTP failures to API responses. Tests cover frontend validation and error messages, plus backend request validation, variant handling, and service-failure responses. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to Invalid test inputs are stopped before evaluation, and service failures receive explicit responses. No remaining merge-blocking issue is established; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changes preserve the existing project-scoped access configuration and improve validation and error handling. Only one additional service attempt is permitted. No introduced security vulnerability was established, but the effects of retrying a request that already completed remotely remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 3c5ca3cf-3b90-48a2-87bb-ab7c9d0b1963
⛔ Files ignored due to path filters (1)
products/feature_flags/frontend/generated/api.schemas.tsis excluded by!**/generated/**
📒 Files selected for processing (6)
frontend/src/scenes/feature-flags/FeatureFlagTestingTab.tsxfrontend/src/scenes/feature-flags/featureFlagTestingLogic.test.tsfrontend/src/scenes/feature-flags/featureFlagTestingLogic.tsproducts/feature_flags/backend/api/feature_flag.pyproducts/feature_flags/backend/api/test/test_feature_flag.pyservices/mcp/src/api/generated.ts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
|
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · Reject JSON null for groups. · featureFlagTestingLogic.ts:115-118
frontend/src/scenes/feature-flags/featureFlagTestingLogic.ts:115-118
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winReject JSON
nullforgroups.
JSON.parse('null')returnsnull, buttypeof null === 'object', so this check accepts it. The new submit guard then dispatches the evaluation loader withgroups: nullinstead of settingtestError. Rejectparsed === nullhere.Proposed fix
- if (typeof parsed !== 'object' || Array.isArray(parsed)) { + if (parsed === null || typeof parsed !== 'object' || Array.isArray(parsed)) {
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 8ab94835-312e-494e-81c2-b96304e28cfe
📒 Files selected for processing (1)
frontend/src/scenes/feature-flags/featureFlagTestingLogic.ts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Malformed JSON responses from the flags service still produce the generic 500 instead of the intended 502.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Improves feature flag test evaluation errors across the backend and frontend.
Changes:
- Accepts blank condition variants and classifies service failures.
- Validates forms before loaders run.
- Displays backend error messages with targeted rewrites.
| File | Description |
|---|---|
services/mcp/src/api/generated.ts |
Updates generated variant documentation. |
products/feature_flags/frontend/generated/api.schemas.ts |
Updates generated frontend schema documentation. |
products/feature_flags/backend/api/test/test_feature_flag.py |
Tests blank variants and service failures. |
products/feature_flags/backend/api/feature_flag.py |
Adds retry and upstream error handling. |
frontend/src/scenes/feature-flags/FeatureFlagTestingTab.tsx |
Routes submissions through logic validation. |
frontend/src/scenes/feature-flags/featureFlagTestingLogic.ts |
Validates input and improves error mapping. |
frontend/src/scenes/feature-flags/featureFlagTestingLogic.test.ts |
Tests validation and error messages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| {"error": "Flag evaluation service temporarily unavailable. Please retry."}, | ||
| status=status.HTTP_503_SERVICE_UNAVAILABLE, | ||
| ) | ||
| except requests.exceptions.HTTPError as e: |
…valuation_reasons
Problem
variant: "". The response serializer rejects the blank value, and the catch-all turns the rejection into a generic 500.evaluationErrorMessageapplies the "person not found" and timestamp rewrites only todetailmessages. The endpoint sends its errors aserror, so those rewrites never match.loadersPlugin.onFailurereports errors that have nostatus, so "Invalid JSON format for groups" goes to error tracking. The user already sees the message inline.Origin
b0f41e2Changes
variantrequestsfailure, such asChunkedEncodingErrorgroupsthat is not a JSON objectgroupsnullincluded) or timestamp in the tabtestError, loader does not runvariantfield onFeatureFlagConditionAnalysisSerializernow allows a blank value. This removes the most frequent 500.evaluation_reasonsin the same file.groupsvalue that is not an object.evaluationErrorMessagenow applies every rewrite to one message.ApiError.messagealready holds theerrorfield. The "invalid timestamp" rewrite matches only real invalid-timestamp errors. Specific reasons such as "did not exist at the specified timestamp" now show as they are.submitTestEvaluationaction checks the form first. It setstestErrorfor invalid input, or else runs the single or the batch evaluation. The "Test" button in the tab now uses it.FeatureFlagTestingTabinto the logic listener.How did you test this code?
TestFeatureFlagTestEvaluationintest_feature_flag.pyandfeatureFlagTestingLogic.test.tslocally. Both pass.groupsas a string or a list returns 400 ongroups.max_retries=1.testErrorand do not dispatchtestFlagEvaluation. This catches a return of the throw inside the loader.errormessages go through the friendly rewrites, and a specific timestamp reason is not rewritten.nullgroups settestError.Release status
Automatic notifications
Docs update
None. No doc under
docs/covers the flag testing tab errors.🤖 Agent context
Autonomy: Fully autonomous
Agent: PostHog Desktop (Claude Code), claude-opus-5-5
test_evaluationerror handling.evaluation_reasons, movedgroupsvalidation into the request serializer, and added the missing tests. Skills: improving-drf-endpoints, writing-tests, writing-code-comments, writing-pr-descriptions.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code