trunk-merge/pr-108026/e2ff5dc3-9b6c-48df-8dd6-3eeba5b6c23b

[trunk-io]

This pull request was created and is being managed by Trunk Merge.

This pull request is based on the master branch at SHA 147ca7bdee5ab14a18bc77c7453560f78203fb6b.

See more details here.

When CI completes, this pull request will be closed automatically.

Pull Requests Being Tested

This pull request is testing the changes from pull request 108026.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

📝 Walkthrough

Walkthrough

The changes add a reusable “New” tag for unviewed observations and use it in the scanner table and watch feed. The watch feed also adds an accent stripe and screen-reader text for unviewed observations. The light snapshot hash is updated.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 143f7

Screen-reader users may hear “New” twice when navigating an unviewed wide watch-feed card. Hide the visual tag from assistive technology while keeping the headline cue; this is a bounded accessibility issue.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 143f7

The shared indicator changes how unviewed observations are presented, not who can open them. The existing viewed-state conditions and navigation remain in place. No security issue was identified in the changed behavior.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed indicator affects the presentation of unviewed status in two existing views, not the set of observation or session identifiers those views can access.

Trust Boundaries and Controls

• inferred — No new identity or authorization transition is visible in the changed UI path: the tag receives styling rather than observation data or an action, while the existing links and clip handler remain the access paths.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only contains Trunk Merge metadata. It does not explain the user-facing problem, changes, testing, release status, documentation impact, or agent context required by the repository tem…	Replace or supplement the Trunk Merge text with the required sections: Problem, Changes, How did you test this code?, Release status, Automatic notifications, Docs update, and Agent context when applicable. Include the Replay Vision unviewe…

Full details: Description check

Explanation

The description only contains Trunk Merge metadata. It does not explain the user-facing problem, changes, testing, release status, documentation impact, or agent context required by the repository template.

Resolution

Replace or supplement the Trunk Merge text with the required sections: Problem, Changes, How did you test this code?, Release status, Automatic notifications, Docs update, and Agent context when applicable. Include the Replay Vision unviewed-state behavior, affected UI components, screenshots for frontend changes, tests actually run, and the selected release-status option.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)

products/replay_vision/frontend/replay_scanners/components/WatchFeedCard.tsx-281-285 (1)

281-285: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Hide the wide-card visual tag with aria-hidden, not a <span> wrapper.

LemonTag renders a <div>, so wrapping UnviewedObservationTag in a <span> creates invalid phrasing-content markup. Add an accessibility prop to UnviewedObservationTag and set it only at the wide-card call site. Keep the headline’s New: cue and the scanner table’s tag unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 076c9a5c-ff29-4ec1-9a74-f72a20a41eef

📥 Commits

Reviewing files that changed from the base of the PR and between 147ca7b and 143f7fc.

📒 Files selected for processing (4)

• frontend/snapshots.yml
• products/replay_vision/frontend/components/UnviewedObservationTag.tsx
• products/replay_vision/frontend/replay_scanners/components/ScannerObservationsTable.tsx
• products/replay_vision/frontend/replay_scanners/components/WatchFeedCard.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

[trunk-io]

   

Failed Test	Failure Summary	Logs
Scenes-App/Feature Flags EditFeatureFlagConditionsWithRealtimeCohort play-test		Logs ↗︎
Scenes-App/SidePanels SidePanelNotebooks smoke-test	The test timed out while waiting for a loading indicator or spinner to disappear.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs