trunk-merge/pr-108005/e50729e7-aea3-46a3-bd47-47bbefa42f08

[trunk-io]

This pull request was created and is being managed by Trunk Merge.

This pull request is based on the master branch at SHA e7c14387b61da5bc584ace3e554f7ee09416bcaa.

See more details here.

When CI completes, this pull request will be closed automatically.

Pull Requests Being Tested

This pull request is testing the changes from pull request 108005.

Dependencies

This pull request depends on the changes from pull requests 107975 and 107756.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

📝 Walkthrough

Walkthrough

The marketing analytics source menu now uses shared notice logic and has new interaction stories and snapshots. Session recording template filter applicability now uses the presence of template filters. The enrichment scoring story waits for editor readiness and formula updates before completing its interaction.

Priority: ➖ Normal

Merge Risk: 🔵 Low · up to a083b

The menu-state implementation should be brought into line with the frontend guidance. No material user-facing failure is established, so this is a bounded merge concern.

Security Architecture Review

Security architecture risk: 🔵 Low · up to a083b

The reviewed changes primarily affect frontend notices and filter interactions. The shared menu retains its project-admin restriction, and no new security exposure was established. Server-side permission enforcement for the linked source-creation flow was not fully verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The observed notice-state change is scoped to the current user's announcement visibility, while the source menu's project restriction is evaluated separately. No change to backend source-creation authority was established.

Trust Boundaries and Controls

• observed — The frontend access check uses the current project's effective membership level; the source API lists create and setup among write-scoped actions. End-to-end server permission enforcement for those actions was not fully traced.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only documents Trunk Merge execution, the tested PR, the base commit, and dependencies. It does not include the required Problem, Changes, How did you test this code?, Release status, …	Replace or supplement the merge-queue text with a standalone description that follows the repository template. Explain the user problem, visible and mechanical changes, automated tests and untested areas, select exactly one release-status o…

Full details: Description check

Explanation

The description only documents Trunk Merge execution, the tested PR, the base commit, and dependencies. It does not include the required Problem, Changes, How did you test this code?, Release status, Automatic notifications, Docs update, or Agent context sections.

Resolution

Replace or supplement the merge-queue text with a standalone description that follows the repository template. Explain the user problem, visible and mechanical changes, automated tests and untested areas, select exactly one release-status option, address changelog and docs updates, and complete or remove the Agent context section as applicable. Keep the merge-queue details only as supporting information if needed.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: b61a0fde-7a33-4fc0-9ec1-77cc7796aa1d

📥 Commits

Reviewing files that changed from the base of the PR and between e7c1438 and a083b45.

📒 Files selected for processing (12)

• frontend/snapshots.yml
• frontend/src/scenes/session-recordings/templates/sessionRecordingTemplatesLogic.test.ts
• frontend/src/scenes/session-recordings/templates/sessionRecordingTemplatesLogic.tsx
• frontend/src/scenes/web-analytics/tabs/marketing-analytics/frontend/components/MarketingAnalyticsFilters/AddIntegrationButton.tsx
• frontend/src/scenes/web-analytics/tabs/marketing-analytics/frontend/components/MarketingAnalyticsFilters/MarketingAnalyticsFilters.tsx
• frontend/src/scenes/web-analytics/tabs/marketing-analytics/frontend/components/settings/ExternalDataSourceConfiguration.tsx
• products/growth/frontend/aiEnrichment/EnrichmentScoring.stories.tsx
• products/marketing_analytics/frontend/components/AddIntegrationButton.stories.tsx
• products/marketing_analytics/frontend/components/AddIntegrationButton.tsx
• products/marketing_analytics/frontend/components/newAdSourcesLogic.test.ts
• products/marketing_analytics/frontend/components/newAdSourcesLogic.ts
• tsconfig.json

💤 Files with no reviewable changes (1)

• frontend/src/scenes/web-analytics/tabs/marketing-analytics/frontend/components/MarketingAnalyticsFilters/AddIntegrationButton.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 0 remain after this review.

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🔎 Supported by static analysis

🏁 Script executed:

sed -n '1,145p' products/marketing_analytics/frontend/components/AddIntegrationButton.tsx
rg -n 'Don.t use `useState`|Always implement data layer in Kea|local state|keyed logic' frontend/src/AGENTS.md products/marketing_analytics frontend/.cursor products/.cursor 2>/dev/null | head -65

Repository: PostHog/posthog

Length of output: 5407

---

🏁 Script executed:

set -e
printf '%s\n' '--- logic definition ---'
sed -n '1,220p' products/marketing_analytics/frontend/components/newAdSourcesLogic.ts 2>/dev/null || true
printf '%s\n' '--- component usages ---'
rg -n -C 3 'AddIntegrationButton' products/marketing_analytics frontend/src
printf '%s\n' '--- logic usages ---'
rg -n -C 3 'newAdSourcesLogic' products/marketing_analytics/frontend

Repository: PostHog/posthog

Length of output: 25295

---

🏁 Script executed:

set -e
printf '%s\n' '--- logic definition ---'
fd -i 'newAdSourcesLogic.ts' products frontend | xargs -r -n1 sh -c 'echo "--- $0"; sed -n "1,220p" "$0"'
printf '%s\n' '--- component usages ---'
rg -n -C 4 'AddIntegrationButton' products/marketing_analytics frontend/src
printf '%s\n' '--- logic usages ---'
rg -n -C 4 'newAdSourcesLogic' products/marketing_analytics/frontend

Repository: PostHog/posthog

Length of output: 29655

---

🏁 Script executed:

python3 - <<'PY'
from pathlib import Path
for p in Path("products/marketing_analytics").rglob("*"):
    if p.name == "newAdSourcesLogic.ts":
        print(f"--- {p} ---")
        print("".join(p.read_text().splitlines(True)[:220]))
print("--- AddIntegrationButton call sites ---")
for root in (Path("products/marketing_analytics"), Path("frontend/src")):
    for p in root.rglob("*"):
        if p.suffix in {".ts", ".tsx"} and p.is_file():
            text = p.read_text(errors="replace")
            if "AddIntegrationButton" in text:
                print(f"--- {p} ---")
                lines = text.splitlines()
                for i, line in enumerate(lines):
                    if "AddIntegrationButton" in line:
                        lo, hi = max(0, i-4), min(len(lines), i+8)
                        print("\n".join(f"{j+1}: {lines[j]}" for j in range(lo, hi)))
PY

Repository: PostHog/posthog

Length of output: 10654

---

Move the menu state into a per-button Kea logic.

The frontend guidance does not exempt transient menu state from its useState rule. Move showPopover and showNoticeInMenu out of React state.

Keep newAdSourcesLogic global for the shared new-source notice and dismissal. Do not add the menu values to that logic. The component renders twice in the story, so the new menu logic must be keyed per button instance. Otherwise, one button's visibility state can affect the other.

[trunk-io]

   

Failed Test	Failure Summary	Logs
Scenes-App/SidePanels SidePanelNotebooks smoke-test	The test timed out while waiting for a loading indicator or spinner to disappear.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs