Skip to content

fix(mcp): derive server version from package #107785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gesh wants to merge 1 commit into from
Closed

fix(mcp): derive server version from package #107785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/mcp/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ export {
} from './oauth-constants'

import { resolveAuthorizationServerUrl } from './oauth-constants'
import packageJson from '../../package.json'

export const getAuthorizationServerUrl = (): string => resolveAuthorizationServerUrl()

export const MCP_SERVER_NAME = 'PostHog'
export const MCP_SERVER_VERSION = '1.0.0'
export const MCP_SERVER_VERSION = packageJson.version

@greptile-apps greptile-apps Bot Sep 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version bumps will fail tests When services/mcp/package.json is bumped, this value will change, but two assertions in request-context.test.ts still require '1.0.0'. The intended version update will fail the Hono tests. Derive those expectations from the package version too.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: services/mcp/src/lib/constants.ts
Line: 24

Comment:
**Version bumps will fail tests** When `services/mcp/package.json` is bumped, this value will change, but two assertions in `request-context.test.ts` still require `'1.0.0'`. The intended version update will fail the Hono tests. Derive those expectations from the package version too.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

export const MCP_ANALYTICS_SOURCE = 'posthog_mcp_analytics'

// Claude Code truncates a server's `instructions` payload at this many characters — silently,
Expand Down
Loading