chore(ci): build the derived sandbox images in their own job - #106653
trunk-io[bot] merged 2 commits into
Conversation
🦔 PostHog Review reviewed this pull requestNothing worth raising this time. Enjoy the moment: |
🤖 CI report
|
|
[High risk] Splits sandbox image builds into a separate CI job. The PR is not ready to merge because the derived-image job publishes packages from pull-request runs. Reviews (2) · Last reviewed commit: "chore(ci): build the derived sandbox ima..." |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: PostHog/posthog/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PostHog/posthog/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workflow adds Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to A master build with deployment disabled can fail while building the derived images. Resolve that workflow condition before merging unless the failure is explicitly accepted. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
Full details: Description checkExplanation The description clearly explains the problem, changes, impact, and CI flow. However, it omits the required “How did you test this code?” section and does not select a release status. It also omits the template’s agent context and notification/docs sections, if applicable. Resolution Add a “How did you test this code?” section with actual automated or manual verification and limitations. Select exactly one release-status option. Complete or explicitly mark the notification, docs, and agent-context sections as applicable or not applicable. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
27363fb to
911b301
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 252ae14e-5d46-42f7-bedc-6bf5cc15774b
📒 Files selected for processing (1)
.github/workflows/cd-sandbox-base-image.yml
Included review availability: Your plan provides up to 12 included reviews per hour; 0 remain after this review.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
911b301 to
08e9377
Compare
|
Stacked PR 106658 failed testing in the merge queue. Please investigate the failure and re-submit the stack. |
08e9377 to
230a6ac
Compare
230a6ac to
8b5380b
Compare
|
This pull request was merged into |
2 participants
Problem
The check a sandbox agent bump waits on, "Sandbox Base Image Smoke", reports 38 s later than it could at p50 and 201 s later at max, because the base image job also builds the pi, autoresearch and vm images after the smoke (run 36044984574, job "Build and push Tasks Sandbox container image": the second parallel group runs for 25 s after the smoke).
Changes
sandbox_derived_build, that needs the base job. The smoke check now reports as soon as the base job ends.Before:
flowchart LR S[build_skills] --> B[sandbox_base_build<br/>base, notebook, streamlit<br/>smoke<br/>pi, autoresearch, vm] B --> C{{Sandbox Base Image Smoke}} B --> P{{Sandbox Base Image Pass}} classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff; classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000; class S,B phBlue; class C,P phYellow;After:
flowchart LR S[build_skills] --> B[sandbox_base_build<br/>base, notebook, streamlit<br/>smoke] B --> C{{Sandbox Base Image Smoke}} B --> D[sandbox_derived_build<br/>pi, autoresearch, vm] D --> P{{Sandbox Base Image Pass}} B --> P classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff; classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000; class S,B,D phBlue; class C,P phYellow;